Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have more relaxed suggest matching algorithm #15419

Closed
godblesshugh opened this issue Nov 13, 2016 · 3 comments
Closed

Have more relaxed suggest matching algorithm #15419

godblesshugh opened this issue Nov 13, 2016 · 3 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality on-testplan suggest IntelliSense, Auto Complete
Milestone
November 2017

Comments

@godblesshugh
Copy link

  • VSCode Version:1.7.1 (1.7.1) 02611b4
  • OS Version:OSX 10.12

Steps to Reproduce:

more like fix than autocomplete the wrong typing, accidentally typed 'rlut' for 'result'.
likes this in sublime.
image
@godblesshugh godblesshugh changed the title can autocomplete more flexible for some wrong typing word can autocomplete more flexible for some 'wrong' typing Nov 13, 2016
@joaomoreno joaomoreno removed their assignment Nov 14, 2016
@joaomoreno joaomoreno added this to the Backlog milestone Nov 14, 2016
@joaomoreno joaomoreno added feature-request Request for new features or functionality suggest IntelliSense, Auto Complete labels Nov 14, 2016
@joaomoreno joaomoreno changed the title can autocomplete more flexible for some 'wrong' typing Have more relaxed suggest matching algorithm Nov 14, 2016
@jrieken jrieken self-assigned this Jun 27, 2017
@jrieken
Copy link
Member

jrieken commented Jun 27, 2017

We do have graceful score but it's not enabled ATM. We could put it behind a user option

@jrieken jrieken modified the milestones: September 2017, Backlog Aug 31, 2017
jrieken added a commit that referenced this issue Sep 4, 2017
@jrieken
some more perf tweaks for #15419
62194ce
@jrieken jrieken modified the milestone: September 2017 Sep 7, 2017
@jrieken jrieken added this to the November 2017 milestone Oct 31, 2017
@jrieken
Copy link
Member

jrieken commented Nov 24, 2017 •
edited

screen shot 2017-11-24 at 15 52 39

I have something and I think it's pretty cool 😎 The logic goes by running a few simple permutations when compute scores. So, with above sample not just rlut but also rult and rltu. That yields in pretty good results, as visible in the screen shot.

Question is if we should do this always or only when the original search, e.g. with rlut didn't produce a match... Sample: cno matches on 'console' but mutating it to to con would yield in 'console' which is the much stronger match.

jrieken added a commit that referenced this issue Nov 24, 2017
@jrieken
when the 'query' string is getting longer it's save to score afore sc…
3d2d63d 
…ored/filtered items only, #15419
jrieken added a commit that referenced this issue Nov 24, 2017
@jrieken
use graceful scoring when possible, #15419
9bdb41a
@jrieken
Copy link
Member

jrieken commented Nov 24, 2017

Closing, please keep an eye open so we can tweak this

@jrieken jrieken closed this as completed Nov 24, 2017
@jrieken jrieken mentioned this issue Dec 4, 2017
Closed
2 tasks
@aeschli aeschli mentioned this issue Dec 4, 2017
Closed
3 tasks
@ramya-rao-a ramya-rao-a mentioned this issue Dec 5, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality on-testplan suggest IntelliSense, Auto Complete
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @godblesshugh