Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl clicking a deep link from the terminal no longer highlights the right line/col #155065

Closed
joaomoreno opened this issue Jul 13, 2022 · 1 comment · Fixed by #155184
Closed

Ctrl clicking a deep link from the terminal no longer highlights the right line/col #155065

joaomoreno opened this issue Jul 13, 2022 · 1 comment · Fixed by #155184
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Milestone
July 2022

Comments

@joaomoreno
Copy link
Member

Ctrl clicking an error from our selfhost build no longer sends me to the right location of the file. It simply opens the file and highlights position (0,0).

image
@bpasero bpasero removed their assignment Jul 13, 2022
@bpasero bpasero added the terminal Integrated terminal issues label Jul 13, 2022
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member terminal-links and removed terminal Integrated terminal issues labels Jul 13, 2022
@meganrogge
Copy link
Contributor

Pretty sure i've seen this too

@meganrogge meganrogge removed their assignment Jul 13, 2022
@Tyriar Tyriar added this to the July 2022 milestone Jul 13, 2022
@Tyriar Tyriar added the important Issue identified as high-priority label Jul 13, 2022
@Tyriar Tyriar mentioned this issue Jul 13, 2022
Closed
Tyriar added a commit that referenced this issue Jul 14, 2022
@Tyriar
Fix link regex groups
2d126f6 
Fixes #155065
@Tyriar Tyriar mentioned this issue Jul 14, 2022
Merged
@Tyriar Tyriar mentioned this issue Jul 14, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 14, 2022
jrieken pushed a commit that referenced this issue Jul 18, 2022
@Tyriar @jrieken
Fix link regex groups
02c3d97 
Fixes #155065
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Fix link regex groups microsoft/vscode
6 participants
@joaomoreno @bpasero @Tyriar @rzhao271 @meganrogge @VSCodeTriageBot