Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt loading progress when running tests #155955

Closed
Tyriar opened this issue Jul 22, 2022 · 1 comment · Fixed by #155957 or #157005
Closed

Adopt loading progress when running tests #155955

Tyriar opened this issue Jul 22, 2022 · 1 comment · Fixed by #155957 or #157005
Assignees
@Tyriar @connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-found Issue verification failed verified Verification succeeded
Milestone
August 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 22, 2022

image

This support was added for tasks:

179767680-8b52615a-8f37-4dde-a4fe-0a8d7b6f4666 (1)

We should use the sync icon when we're synchronizing something (git fetch, checking tasks.json, etc.) and loading when work is happening that wouldn't be classified as syncing.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Jul 22, 2022
@Tyriar Tyriar added this to the July 2022 milestone Jul 22, 2022
Tyriar added a commit that referenced this issue Jul 22, 2022
@Tyriar
Use loading for running tests window progress
504115b 
Fixes #155955
@Tyriar Tyriar mentioned this issue Jul 22, 2022
Merged
connor4312 pushed a commit that referenced this issue Jul 25, 2022
@Tyriar
Use loading for running tests window progress (#155957)
ba6088a 
Fixes #155955
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 25, 2022
@lramos15 lramos15 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Jul 28, 2022
@lramos15
Copy link
Member

Running unit tests in the vscode repo I still see the sync icon.

@lramos15 lramos15 reopened this Jul 28, 2022
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jul 28, 2022
@bpasero bpasero modified the milestones: July 2022, August 2022 Jul 30, 2022
Tyriar added a commit that referenced this issue Aug 3, 2022
@Tyriar
Pass progress type along in notification updates
e614dac 
Fixes #155955
@Tyriar Tyriar mentioned this issue Aug 3, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 3, 2022
@Tyriar Tyriar added the verified Verification succeeded label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
August 2022
5 participants
@bpasero @Tyriar @connor4312 @lramos15 @VSCodeTriageBot