Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview pane does not show output [SQL Results, Markdown Preview, etc] #15623

Closed
peterblazejewicz opened this issue Nov 17, 2016 · 8 comments
Closed

Preview pane does not show output [SQL Results, Markdown Preview, etc] #15623

peterblazejewicz opened this issue Nov 17, 2016 · 8 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
November 2016

Comments

@peterblazejewicz
Copy link

  • VSCode Version:
    Version 1.8.0-insider
    Commit 1b95a2f
    Date 2016-11-17T00:36:45.332Z
    Shell 1.4.6
    Renderer 53.0.2785.143
    Node 6.5.0
  • OS Version: Windows 10 Enterprise

Steps to Reproduce:

  1. Open Markdown file .md
  2. Choose Open Preview command

Expected:
The rendered Markdown preview is shown
Actual:
Blank pane is rendered (no content)

The Markdown issue is the quickest to reproduce. Similar issue with vscode-mssql extension (Connect 2016 thing):
microsoft/vscode-mssql#361

Thanks!
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Nov 17, 2016
@bpasero
Copy link
Member

bpasero commented Nov 17, 2016 •
edited

This is probably 0cef61f

/cc @jrieken

@jrieken
Copy link
Member

jrieken commented Nov 17, 2016

same for extension. open extension viewlet, select extension, detail-tab stays empty

@jrieken
Copy link
Member

jrieken commented Nov 17, 2016

@mjbvz Pretty sure this happens because when building you must explicitly include the pre-file as we do it with webview.html. Sorry for not spotting that

@jrieken jrieken added this to the November 2016 milestone Nov 17, 2016
jrieken added a commit that referenced this issue Nov 17, 2016
@jrieken
list webview-pre as required resource, #15623
41a2317
@jrieken
Copy link
Member

jrieken commented Nov 17, 2016

fyi - I have pushed a change to master and triggered new insiders builds for this

@bpasero
Copy link
Member

bpasero commented Nov 17, 2016

@jrieken should also be added to the release/1.7 branch where I think @mjbvz change also landed?

jrieken added a commit that referenced this issue Nov 17, 2016
@jrieken
uglify and JS synatx from yesteryear, #15623
043310a
@jrieken
Copy link
Member

jrieken commented Nov 17, 2016

I leave that to @mjbvz

@peterblazejewicz
Copy link
Author

This seems to be published and fixed at least on the OS X (I have yet to verify this at Win machine at work). Thanks!

mjbvz pushed a commit that referenced this issue Nov 17, 2016
@jrieken @mjbvz
list webview-pre as required resource, #15623
07e605e
@mjbvz
Copy link
Contributor

mjbvz commented Nov 17, 2016

Thanks for catching this. @jrieken, I've cherry-picked the fix into 1.7 as well: 07e605e

@mjbvz mjbvz closed this as completed Nov 17, 2016
kieferrm pushed a commit that referenced this issue Nov 21, 2016
@jrieken @kieferrm
uglify and JS synatx from yesteryear, #15623
9ed81c4
@dbaeumer dbaeumer added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
5 participants
@peterblazejewicz @bpasero @jrieken @dbaeumer @mjbvz