Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropped support for relative paths in launch.json: UX problems #1575

Closed
weinand opened this issue Dec 22, 2015 · 7 comments
Closed

dropped support for relative paths in launch.json: UX problems #1575

weinand opened this issue Dec 22, 2015 · 7 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
Jan 2016

Comments

@weinand
Copy link
Contributor

weinand commented Dec 22, 2015

When using old launch.jsons with relative paths, VSCode throws warnings into the users face.
I don't think that we can ship with this in January.

  • the warning doesn't specify what attributes are affected, instead I see only the value that I will have to fix. Since the fix has already been applied to the value, it is difficult to locate the value in the lunch.json.
    2015-12-22 13-48-36
  • "${workspaceRoot}/." (and variants) look a bit silly. This is just "${workspaceRoot}"
  • Sometimes it is impossible to figure out what to do. This launch.json looks OK but VSCode still complains that there is a "." somewhere. I couldn't spot the error: 2015-12-22 13-40-40.

In general I think that we should not show warnings in this way because it is annoying and unhelpful. Instead we should show warning (later "error") squigglies in the json editor and offer intellisense to help the user inserting the missing "${workspaceRoot}" and have a "light bulb" action for fixing the whole launch json (as an example use the validation that got introduced for the Keyboard Shortcuts json).

If this is not possible for January, I suggest that we only fix our intellisense, templates, samples, etc. but show no warnings in the launch.json editor.
@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 22, 2015
@weinand weinand added this to the Jan 2016 milestone Dec 22, 2015
@weinand weinand changed the title no support for relative paths in launch.json: UX problems dropped support for relative paths in launch.json: UX problems Dec 22, 2015
@isidorn
Copy link
Contributor

isidorn commented Dec 22, 2015

👍 we should improve this, I will look into how to make this experience nicer

@egamma
Copy link
Member

egamma commented Dec 22, 2015

Do we need to update the yo code generator as well?

@isidorn
Copy link
Contributor

isidorn commented Dec 22, 2015

Yes, I will update it.

@isidorn
Copy link
Contributor

isidorn commented Dec 22, 2015

All yo code generator templates use ${execPath} for their program attributes, so no updates are needed.

@isidorn
Copy link
Contributor

isidorn commented Dec 22, 2015

What exact keyboard shortcut validation are you refering to?
For inserting squiggles into the editor I am not even sure our json schema can support that. @aeschli is it possible to provide validation rules based on the value of a string field.

I propose that instead of having smart inteli-sense and light bulbs, we just automatically update the content of the launch.json for the user and show an info message such that he is aware of what is going on.

@weinand
Copy link
Contributor Author

weinand commented Dec 22, 2015

@isidorn switch your OS X keyboard layout to Swiss German and open the keyboard shortcuts. Then scroll through the list and you will see that some bindings show adornments (he basically looks at the keyboard strings and validates that they can be produced by the current keyboard layout) . Alex demoed this in the standup last week. @aeschli is out of the loop because this is semantic validation which is not covered by the json schema. But since we need this anyway in the future we should support semantic validation and Alex has implemented it in a day or so...

@isidorn
Copy link
Contributor

isidorn commented Jan 12, 2016

We are now showing a warning message in the launch.json if the user uses a relative paths and we do not spam with msgs on top of screen.
Please note that the shown message is not a good one since @aeschli has to start supporting .errorMessage field in schema which he plans to do this sprint.

@isidorn isidorn assigned weinand and unassigned isidorn Jan 12, 2016
@weinand weinand added the verified Verification succeeded label Jan 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
Jan 2016
Development

No branches or pull requests
3 participants
@egamma @weinand @isidorn