Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tab close "x" to left-side for easy access #15833

Closed
brendandixon opened this issue Nov 21, 2016 · 7 comments · Fixed by #17863
Closed

Move tab close "x" to left-side for easy access #15833

brendandixon opened this issue Nov 21, 2016 · 7 comments · Fixed by #17863
Assignees
@bpasero
Labels
feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues
Milestone
January 2017

Comments

@brendandixon
Copy link

  • VSCode Version: Code 1.7.1 (02611b4, 2016-11-03T13:46:00.226Z)
  • OS Version: Darwin x64 16.0.0
  • Extensions:
Extension Author Version
xml DotJoshJohnson 1.6.0
vscode-docker PeterJausovec 0.0.7
code-settings-sync Shan 2.3.8
githistory donjayamanne 0.1.0
python donjayamanne 0.5.2
haml groksrc 0.0.2
Go lukehoban 0.6.49
csharp ms-vscode 1.5.2
Ruby rebornix 0.10.2

Steps to Reproduce:

  1. Open multiple tabs
  2. See how the closing "x" in on the right-side? Move it to the left-side.

One of the things Safari gets right is its placement of the tab close "x". By placing it on the left, you can quickly close tabs without moving the pointer about (since the left-side remains constant, while the right-side moves about based on tab name). It would be nice if VSCode did likewise. :)
@TheColorRed
Copy link

TheColorRed commented Nov 21, 2016 •
edited

Why not just middle mouse click on the tab... or just "Right click" and select "Close to the right"? That is even less clicks...

@brendandixon
Copy link
Author

@TheColorRed Far, far less obvious and it is more clicks: One right-click to bring up the menu, second click to select "Close to the right." Better a single click on a left-justified "x". It's why Safari works this way.

@TheColorRed
Copy link

I don't see where you get more clicks from...

  • Option 1 (middle mouse click): 1 click per tab
  • Option 2 (close to the right): 2 clicks for unlimited number of tabs

@brendandixon
Copy link
Author

@TheColorRed Try Safari and you'll see the feature I'm after. I don't want to always close all tabs to the right.

@TheColorRed
Copy link

@brendandixon I understand what you're saying... What I am saying is just place your mouse on the left side of the tab (or anywhere on the tab), and just middle mouse click it. You will get the same close effect.

@bpasero bpasero added feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues labels Nov 22, 2016
@bpasero bpasero removed their assignment Nov 22, 2016
@bpasero bpasero changed the title [feature] Move tab close "x" to left-side for easy access Move tab close "x" to left-side for easy access Nov 22, 2016
@bpasero bpasero mentioned this issue Dec 20, 2016
Closed
@reaktivo
Copy link
Contributor

@bpasero @jrieken Would a external contributor's PR for this feature be considered?

@bpasero
Copy link
Member

bpasero commented Dec 20, 2016

@reaktivo yes, we are always open to PRs as long as they make sense 👍

@reaktivo reaktivo mentioned this issue Dec 27, 2016
Merged
reaktivo added a commit to reaktivo/vscode that referenced this issue Dec 28, 2016
@reaktivo @mmiranda-travix
Fixes microsoft#15833 Adds support for moving the tab close button to…
b604568 
… the left
@bpasero bpasero added this to the January 2017 milestone Jan 18, 2017
@bpasero bpasero added the verification-needed Verification of issue is requested label Jan 18, 2017
@bpasero bpasero self-assigned this Jan 18, 2017
@bpasero bpasero mentioned this issue Jan 19, 2017
Closed
2 tasks
@bpasero bpasero removed the verification-needed Verification of issue is requested label Jan 19, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
January 2017
Development

Successfully merging a pull request may close this issue.

Adds support for moving the tab close button to the left reaktivo/vscode
4 participants
@reaktivo @brendandixon @bpasero @TheColorRed