Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctrl+shift+j yields "Cannot read property 'openViewlet' of undefined" #1599

Closed
rhbecker opened this issue Dec 23, 2015 · 4 comments
Closed

ctrl+shift+j yields "Cannot read property 'openViewlet' of undefined" #1599

rhbecker opened this issue Dec 23, 2015 · 4 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
Jan 2016

Comments

@rhbecker
Copy link

explanation

The default keyboard shortcuts file contains:

{
  "key": "ctrl+shift+j",
  "command": "workbench.action.search.toggleQueryDetails",
  "when": "searchViewletVisible"
},

So, I tried it out, but got an error.

repro

  1. Open search view (via ctrl+shift+f or mouse click).
  2. Attempt to use shortcut ctrl+shift+j.
  3. See error message: "Cannot read property 'openViewlet' of undefined".

supporting info

  • version: 0.10.5
  • --disable-extensions didn't help
  • no errors appear in the dev tools console
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 23, 2015
@bpasero bpasero added this to the Backlog milestone Dec 23, 2015
@bpasero
Copy link
Member

bpasero commented Dec 23, 2015

@jrieken I can reproduce, somehow the viewletService is not defined in the command.

@jrieken jrieken modified the milestones: Jan 2016, Backlog Dec 23, 2015
@jrieken
Copy link
Member

jrieken commented Dec 23, 2015

Good catch!

@Roustalski
Copy link

When will this fix be released? Is there a pre-release or beta version we can grab, or another way of getting to the advanced query section?

@egamma
Copy link
Member

egamma commented Jan 16, 2016

@Roustalski this will be part of the January milestone (see the milestone attribute). If this isn't soon enough we can look into alternative ways to make it available 😄

@jrieken jrieken assigned alexdima and unassigned jrieken Jan 28, 2016
@bpasero bpasero assigned weinand and unassigned alexdima Jan 29, 2016
@weinand weinand added the verified Verification succeeded label Jan 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
Jan 2016
Development

No branches or pull requests
7 participants
@Roustalski @egamma @rhbecker @bpasero @jrieken @weinand @alexdima