Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong indentation of block comments. #1609

Closed
mysticatea opened this issue Dec 23, 2015 · 2 comments
Closed

Wrong indentation of block comments. #1609

mysticatea opened this issue Dec 23, 2015 · 2 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
Jan 2016

Comments

@mysticatea
Copy link

Thank you for fixed #348.

Still, there is a case that Indent operation for block comments is wrong.

wrong-indent

If there is a empty line in a block comment, after the empty line, a space followed by the first * on every line is lost.

We would often encounter this case if files.trimTrailingWhitespace setting is enabled.

Version 0.10.5
Commit dfc08dc9edf6607483b193bf934d3badc3fa2e11
Date 2015-12-17T16:08:04.766Z
Shell 0.34.5
Renderer 45.0.2454.85
Node 4.1.1

On Windows 7 Pro 64bit
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 23, 2015
@bpasero bpasero added this to the Backlog milestone Dec 23, 2015
@alexdima alexdima modified the milestones: Jan 2016, Backlog Jan 11, 2016
@mysticatea
Copy link
Author

Thank you very much!

@alexdima
Copy link
Member

Thank you for reporting and being patient with me 👍

@bpasero bpasero assigned weinand and unassigned alexdima Jan 29, 2016
@weinand weinand added the verified Verification succeeded label Jan 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
Jan 2016
Development

No branches or pull requests
4 participants
@bpasero @weinand @mysticatea @alexdima