Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getmac-dependency #16151

Closed
jrieken opened this issue Nov 28, 2016 · 3 comments
Closed

Remove getmac-dependency #16151

jrieken opened this issue Nov 28, 2016 · 3 comments
Assignees
@seanmcbreen
Labels
debt Code quality issues
Milestone
April 2017

Comments

@jrieken
Copy link
Member

jrieken commented Nov 28, 2016

There is now networkInterfaces in the os module such that we don't need that dependency anymore. It's faster because it doesn't need to launch a command
@jrieken
Copy link
Member Author

jrieken commented Nov 28, 2016

from #16065

@jrieken jrieken added the debt Code quality issues label Nov 28, 2016
jrieken added a commit that referenced this issue Dec 2, 2016
@jrieken
run alternative machine id experiment, #16151
9554aa4
jrieken added a commit that referenced this issue Dec 2, 2016
@jrieken
also log missing id cases #16151
da2f0ee
@jrieken jrieken added this to the November 2016 milestone Dec 5, 2016
@jrieken
Copy link
Member Author

jrieken commented Dec 7, 2016

data was stored in 'common.machineIdExperiment'

@jrieken jrieken modified the milestones: January 2017, November 2016 Dec 7, 2016
@jrieken jrieken modified the milestones: February 2017, January 2017 Jan 23, 2017
@jrieken jrieken assigned seanmcbreen and unassigned jrieken and ramya-rao-a Feb 15, 2017
@bpasero bpasero modified the milestones: February 2017, March 2017 Feb 24, 2017
@rebornix rebornix modified the milestones: April 2017, March 2017 Mar 30, 2017
@jrieken
Copy link
Member Author

jrieken commented Mar 31, 2017

I'd say this is obsolete or not really possible with the node api...

@jrieken jrieken closed this as completed Mar 31, 2017
@ramya-rao-a ramya-rao-a mentioned this issue May 15, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seanmcbreen seanmcbreen

Labels
debt Code quality issues
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
5 participants
@rebornix @bpasero @seanmcbreen @jrieken @ramya-rao-a