Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Sync: consider if "on" notification needs link to log #163013

Closed
daviddossett opened this issue Oct 7, 2022 · 1 comment
Closed

Settings Sync: consider if "on" notification needs link to log #163013

daviddossett opened this issue Oct 7, 2022 · 1 comment
Assignees
@sandy081
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue settings-sync
Milestone
November 2022

Comments

@daviddossett
Copy link
Contributor

Wasn't sure why we show this link when turning Settings Sync on. Do we need it for some reason? Seems somewhat low-level/technical. If so, maybe it should be after the string e.g. Settings Sync is turned on. Show log.

CleanShot 2022-10-07 at 15 43 07@2x
@sandy081 sandy081 added the polish Cleanup and polish issue label Nov 10, 2022
@sandy081 sandy081 added this to the November 2022 milestone Nov 10, 2022
@sandy081
Copy link
Member

Yah, it was added in the beginning for users to discover what is happening. But, I agree that it does not has to be user facing.

sandy081 added a commit that referenced this issue Nov 10, 2022
@sandy081
Fix #163013
196bbdd
@sandy081 sandy081 mentioned this issue Nov 10, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue settings-sync
Projects
None yet
Milestone
November 2022
Development

No branches or pull requests
4 participants
@TylerLeonhardt @sandy081 @daviddossett @VSCodeTriageBot