Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] Support Shift+Click on folding marker to recursively unfold #16517

Closed
EthanMelamed opened this issue Dec 5, 2016 · 13 comments
Closed
Assignees
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality on-testplan
Milestone

Comments

@EthanMelamed
Copy link

Please add the ability to recursively expand code blocks by clicking on the expand icon. Perhaps a shift+click would be an intuitive event to trigger this.

@EthanMelamed
Copy link
Author

I have been using the [command] + [k], [command] + [0] command to collapse my code. When you do this all of the code in the file is recursively collapsed. Being able to recursively expand would save me a lot of time clicking the expand button!

@aeschli
Copy link
Contributor

aeschli commented Dec 7, 2016

There already us 'Unfold recursively (Ctrl+k Ctrl + ])'. Is that what you meant?

@aeschli aeschli added the info-needed Issue requires more information from poster label Dec 7, 2016
@EthanMelamed
Copy link
Author

Yes this is what I mean! Except that you must have your cursor in the code block already for it to work. I was hoping for this same effect to happen when you click the '+' or 'unfold/expand' icon on the line when accompanied by some keypress

@aeschli aeschli changed the title Recursive Expand selection [folding] Support Shift+Click on folding marker to recursivly unfold Dec 9, 2016
@aeschli aeschli added feature-request Request for new features or functionality editor-folding Editor code folding issues and removed info-needed Issue requires more information from poster labels Dec 9, 2016
@aeschli aeschli added this to the Backlog milestone Dec 9, 2016
@aeschli
Copy link
Contributor

aeschli commented Dec 9, 2016

I updated the title. I picked 'shift' as modifier key, feel free to change it to the key of your choice

@EthanMelamed EthanMelamed changed the title [folding] Support Shift+Click on folding marker to recursivly unfold [folding] Support Shift+Click on folding marker to recursively unfold Dec 20, 2016
@EthanMelamed
Copy link
Author

Hello! Is there anyway we can bump this?
Thank you!

@aeschli
Copy link
Contributor

aeschli commented May 18, 2017

We'd need more requests ('thumbs ups') from others for the feature. I'm also happy to accept a pull request.

@EthanMelamed
Copy link
Author

Ok that's fair thanks for the quick reply

@adenflorian
Copy link
Contributor

I'm interested in implementing this, however I would prefer to use middle mouse click (like jetbrains IDEs), and for it to also allow recursively folding. @EthanMelamed @aeschli Would y'all be ok with this?

@EthanMelamed
Copy link
Author

Hey thanks for doing that and sorry for the late reply, middle mouse click is nice but it doesn't help trackpad users, would it be hard to implement something for trackpad users like myself?

@aeschli aeschli modified the milestones: Backlog, November 2017 Nov 20, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 20, 2017

@adenflorian Yes, sounds great, thanks!

I added 'shift + click' also works to recursively fold/unfold.

@EthanMelamed
Copy link
Author

@aeschli 'shift + click' sounds awesome! I looked at the merge pr but didnt see anything about it though. Is there another pr that has it?

@adenflorian
Copy link
Contributor

@EthanMelamed It's in this commit: 12c6aaa

@EthanMelamed
Copy link
Author

Great thanks for linking it!

@aeschli aeschli mentioned this issue Dec 4, 2017
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants