-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing tabs using mouse wheel click turns cursor into auto scroll #16690
Comments
I am not seeing this on my Windows 10 so I assume this is also mouse/configuration dependent. |
I have pretty same issue. I don't even need scroll-able tab container to reproduce it.
Mouse cursor turn into 8-way arrows depends on its position. Also it correspond to #12623 Version 1.12.0-insider |
This problem only happens when I set my DPI scale to 125%, all other values (100%, 150% and 175%) are ok. Middle click at anywhere triggers scrolling, not only the tab bar. I tried to add EDIT: Resizing the window sometimes makes the problem to disappear, and the problem may or may not appear again when resize again. Tried many times but can't find any relation with the window size/ratio. |
Yes, very annoying. Happens all the time when window is maximized. When it isn't seems to work fine. |
Since I cannot reproduce this, I cannot help. If someone has ideas, here are instructions how to run VS Code from source: https://github.com/Microsoft/vscode/wiki/How-to-Contribute |
It has been fixed in the latest stable release. I have not encountered this problem after the update. |
I'm running 1.17.2 on Windows 10 and still have this issue. |
Should have mentioned, all the tabs are being created and styled in |
I have not encountered this issue for a while now, It must have been patched in one of the updates. |
As @yume-chan mentioned... I had my scaling set to 125%. I changed it to 100% scaling and the issue was alleviated. I'm adjusting my font settings to look as I'd like, but it would be nice if this issue was fixed so that the middle click to close a tab worked regardless of if a monitor was scaled or not. |
@efroim102 @sleutho @megakoresh @yume-chan @pawlikooo can you verify that 125% scaling reproduces the issue and 100% scaling "fixes" it? |
Yes, can confirm. |
Yes, just switched from 100% to 125% - still have annoying scroll mode. Turn back to 100% - it works fine. Windows 10 Pro |
Can someone enlighten me how to get this scroll-with-middle-mouse feature to work? Is this a mouse setting? |
Actually I can reproduce... |
Looks like a |
It is still reproducible in version 1.18.1 on Windows 10. Really waiting for this fix. |
It absolutely is, I think we will need to wait for next release for the fix to be merged. |
Yeah I can still reproduce, weird. I pushed another change to call |
@yume-chan @megakoresh @ostap1010 can you give todays insider build a try to see if the issue is now fixed? You can give our preview releases a try from: https://code.visualstudio.com/insiders/ |
Checked on latest version few minutes ago with 125% scaling:
Version 1.19.0-insider |
@pawlikooo yeah good catch, I addressed that via d784938 |
Steps to Reproduce:
When closing tabs using scroll wheel click, I shouldn't need to click away to get a normal cursor.
The text was updated successfully, but these errors were encountered: