Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing tabs using mouse wheel click turns cursor into auto scroll #16690

Closed
efroim102 opened this issue Dec 6, 2016 · 23 comments
Closed

Closing tabs using mouse wheel click turns cursor into auto scroll #16690

efroim102 opened this issue Dec 6, 2016 · 23 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone

Comments

@efroim102
Copy link

  • VSCode Version: 1.7.2
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open multiple files at a time until the tab menu is scroll-able.
  2. Click on an open tab using the mouse wheel, the tab will close, but the cursor will turn into auto scroll (css: all-scroll) and when you move the mouse it will scroll the tab menu.

When closing tabs using scroll wheel click, I shouldn't need to click away to get a normal cursor.

@bpasero
Copy link
Member

bpasero commented Dec 7, 2016

I am not seeing this on my Windows 10 so I assume this is also mouse/configuration dependent.

@bpasero bpasero added help wanted Issues identified as good community contribution opportunities workbench-tabs VS Code editor tab issues bug Issue identified by VS Code Team member as probable bug labels Dec 7, 2016
@bpasero bpasero added this to the Backlog milestone Dec 7, 2016
@pawlikooo
Copy link

I have pretty same issue. I don't even need scroll-able tab container to reproduce it.

  1. Open single file.
  2. Click on an open tab using the mouse wheel.

Mouse cursor turn into 8-way arrows depends on its position.
Nothing scrolling on mouse move: neither tabs nor code.
Have to click middle mouse one more time to escape mouse scrolling mode.

Also it correspond to #12623

Version 1.12.0-insider
Commit 48ae6e3
Date 2017-04-26T06:13:08.212Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0

@yume-chan
Copy link
Contributor

yume-chan commented Aug 20, 2017

This problem only happens when I set my DPI scale to 125%, all other values (100%, 150% and 175%) are ok.

Middle click at anywhere triggers scrolling, not only the tab bar.

I tried to add * { overflow: hidden !important; } but it doesn't help.

EDIT: Resizing the window sometimes makes the problem to disappear, and the problem may or may not appear again when resize again. Tried many times but can't find any relation with the window size/ratio.

@megakoresh
Copy link

Yes, very annoying. Happens all the time when window is maximized. When it isn't seems to work fine.

@bpasero
Copy link
Member

bpasero commented Oct 26, 2017

Since I cannot reproduce this, I cannot help. If someone has ideas, here are instructions how to run VS Code from source: https://github.com/Microsoft/vscode/wiki/How-to-Contribute

@bpasero bpasero added the good first issue Issues identified as good for first-time contributors label Oct 26, 2017
@megakoresh
Copy link

It has been fixed in the latest stable release. I have not encountered this problem after the update.

@sleutho
Copy link

sleutho commented Oct 26, 2017

I'm running 1.17.2 on Windows 10 and still have this issue.
Even if I'd get a source sandbox running, I have no idea where I would even begin to diagnose this.

@bpasero
Copy link
Member

bpasero commented Oct 26, 2017

Should have mentioned, all the tabs are being created and styled in tabsTitleControl.ts

@efroim102
Copy link
Author

I have not encountered this issue for a while now, It must have been patched in one of the updates.

@ghost
Copy link

ghost commented Nov 2, 2017

As @yume-chan mentioned... I had my scaling set to 125%. I changed it to 100% scaling and the issue was alleviated.

I'm adjusting my font settings to look as I'd like, but it would be nice if this issue was fixed so that the middle click to close a tab worked regardless of if a monitor was scaled or not.

@bpasero
Copy link
Member

bpasero commented Nov 3, 2017

@efroim102 @sleutho @megakoresh @yume-chan @pawlikooo can you verify that 125% scaling reproduces the issue and 100% scaling "fixes" it?

@megakoresh
Copy link

Yes, can confirm.

@pawlikooo
Copy link

Yes, just switched from 100% to 125% - still have annoying scroll mode. Turn back to 100% - it works fine.

Windows 10 Pro
VSCode 1.18.0-insider

@bpasero
Copy link
Member

bpasero commented Nov 3, 2017

Can someone enlighten me how to get this scroll-with-middle-mouse feature to work? Is this a mouse setting?

@bpasero
Copy link
Member

bpasero commented Nov 3, 2017

Actually I can reproduce...

@bpasero bpasero modified the milestones: Backlog, October 2017 Nov 3, 2017
@bpasero bpasero removed good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Nov 3, 2017
@bpasero bpasero closed this as completed in 86e057c Nov 3, 2017
@bpasero
Copy link
Member

bpasero commented Nov 3, 2017

Looks like a return false from the mouse-down handler fixes it. The issue is that the tabs container is a scrollable element and middle mouse click should not start to scroll-lock with the mouse because this action is already taken by the close-tab behaviour.

@ostap1010
Copy link

It is still reproducible in version 1.18.1 on Windows 10. Really waiting for this fix.

@megakoresh
Copy link

It absolutely is, I think we will need to wait for next release for the fix to be merged.

@yume-chan
Copy link
Contributor

@bpasero I finally have my problematic PC back, and I really don't want to say: the problem is still reproducible.

I'm using:

Version 1.19.0-insider
Commit 89b158e
Date 2017-11-24T05:14:03.606Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

@bpasero bpasero reopened this Nov 27, 2017
@bpasero bpasero removed this from the October 2017 milestone Nov 27, 2017
@bpasero bpasero added help wanted Issues identified as good community contribution opportunities and removed workbench labels Nov 27, 2017
@bpasero
Copy link
Member

bpasero commented Nov 27, 2017

Yeah I can still reproduce, weird. I pushed another change to call preventDefault() on the mouse event and that seems to help. We will have an insiders build tomorrow to give it a spin and verify.

@bpasero bpasero reopened this Nov 27, 2017
@bpasero bpasero added this to the November 2017 milestone Nov 27, 2017
@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label Nov 27, 2017
@bpasero
Copy link
Member

bpasero commented Nov 28, 2017

@yume-chan @megakoresh @ostap1010 can you give todays insider build a try to see if the issue is now fixed? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@pawlikooo
Copy link

Checked on latest version few minutes ago with 125% scaling:

  • Middle mouse click on tab works like a charm.
  • Middle mouse click on empty space in tab bar still force scroll mode with zero reaction on moving mouse.
  • Same with double middle mouse click (expected new "Untitled-1" tab).

Version 1.19.0-insider
Commit d88e713
Date 2017-11-28T05:13:37.597Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

bpasero added a commit that referenced this issue Nov 28, 2017
@bpasero
Copy link
Member

bpasero commented Nov 28, 2017

@pawlikooo yeah good catch, I addressed that via d784938

@bpasero bpasero closed this as completed Nov 28, 2017
@mjbvz mjbvz added the verified Verification succeeded label Dec 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

8 participants