Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook diff element layouts on each config change? #170972

Closed
bpasero opened this issue Jan 10, 2023 · 0 comments
Closed

Notebook diff element layouts on each config change? #170972

bpasero opened this issue Jan 10, 2023 · 0 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-diff perf verified Verification succeeded
Milestone
January 2023

Comments

@bpasero
Copy link
Member

bpasero commented Jan 10, 2023

These 2 methods are called when any setting changes:

vscode/src/vs/workbench/contrib/notebook/browser/diff/diffComponents.ts

Line 374 in e6b39b8

this.layout({ metadataHeight: metadataLayoutChange, outputTotalHeight: outputLayoutChange });

vscode/src/vs/workbench/contrib/notebook/browser/diff/diffComponents.ts

Line 814 in e6b39b8

this.layout({ metadataHeight: metadataLayoutChange, outputTotalHeight: outputLayoutChange });

I would have expected an early return if no related setting changed.
@bpasero bpasero added the perf label Jan 10, 2023
@roblourens roblourens removed their assignment Jan 10, 2023
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-diff and removed notebook labels Jan 10, 2023
@rebornix rebornix added this to the January 2023 milestone Jan 10, 2023
rebornix added a commit that referenced this issue Jan 24, 2023
@rebornix
Fix #170972. Update diff layout only when affected settings change.
0eca210
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 24, 2023
@bpasero bpasero added the verified Verification succeeded label Jan 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-diff perf verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
4 participants
@roblourens @rebornix @bpasero @VSCodeTriageBot