Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is vs/test? #17110

Closed
jrieken opened this issue Dec 13, 2016 · 2 comments
Closed

What is vs/test? #17110

jrieken opened this issue Dec 13, 2016 · 2 comments
Assignees
@sandy081
Labels
debt Code quality issues
Milestone
January 2017

Comments

@jrieken
Copy link
Member

jrieken commented Dec 13, 2016

In the main folder have some sort of laying and I can no clue what vs/test is supposed to be? The current ideas are outlined here https://github.com/Microsoft/vscode/wiki/Code-Organization#layers and it seems like test should be moved into workbench
@sandy081 sandy081 added the debt Code quality issues label Dec 13, 2016
@sandy081 sandy081 added this to the January 2017 milestone Dec 13, 2016
@sandy081
Copy link
Member

@jrieken I created vs/test to have a common/shared test utilities for all our tests. Like

  • test Instantiation service mock that can stub services. Also has stubs for some known services
  • promise utility
  • service test utility - This got mixed with too much of utilities. This used to contain utilities mainly for workbench but it grew beyond that.

But I accept that this should not break the layering. I would move them into respective layers as debt work.

Thanks for filing an issue for it.

sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Move instantiation mock to platform/instantiaion layer
7e92bd8
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Adopt servicesTestUtils to use new instantiation service mock
7e293a4
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Move promise utils to base test common layer
eb413eb
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Remove dependency on service test utils from platform tests
c07a26c
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Move service test utils to workbench
cf385bc
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Remove dependency on workbench test utils
9852e73
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Rename and clean up
5985a81
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Rename and clean up
d679692
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Move sinon.d.ts to test folder
1380032
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Move sinon to fix compilation issue
762d4d4
sandy081 added a commit that referenced this issue Dec 13, 2016
@sandy081
#17110 Remove reference to HistoryService
0214d86
sandy081 added a commit that referenced this issue Dec 14, 2016
@sandy081
#17110 Move d.ts files to typings folder
30b1cf8
@sandy081
Copy link
Member

Moved ServicesTestUtils to under workbench/test folder and renamed it to WorkbenchTestServices as it contains mocked services for workbench. Since it contains references to browser/node and tests from all other layers are depending on it, I am leaving it at root.

@sandy081 sandy081 closed this as completed Jan 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
2 participants
@jrieken @sandy081