Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not render ?/? in inline completion toolbar #172142

Closed
isidorn opened this issue Jan 24, 2023 · 2 comments · Fixed by #172372
Closed

Do not render ?/? in inline completion toolbar #172142

isidorn opened this issue Jan 24, 2023 · 2 comments · Fixed by #172372
Assignees
@hediet
Labels
inline-completions insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone
January 2023

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2023

Testing #172029

When the inline hover shows up for a split second you render ?/? or something like that - since you do not know how many completions there will be.
I find this visually noisy, could we improve this? So we say 1/1 initially, or even better we render it only once we know how many completion suggestions there are?
@isidorn
Copy link
Contributor Author

isidorn commented Jan 24, 2023

Clicking on Accept Part leads me to this weird 1/? state

Screenshot 2023-01-24 at 12 57 47

@rebornix
Copy link
Member

I often see 1/? while deleting characters.

@hediet hediet mentioned this issue Jan 25, 2023
Merged
hediet added a commit that referenced this issue Jan 25, 2023
@hediet
Fixes #172142
a4de6ce
hediet added a commit that referenced this issue Jan 25, 2023
@hediet
Fixes #172142 (#172372)
f1f9b53
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 25, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Jan 25, 2023
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2023
@hediet hediet added polish Cleanup and polish issue and removed bug Issue identified by VS Code Team member as probable bug labels Jan 25, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 26, 2023
@andreamah andreamah added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
inline-completions insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Fixes #172142 microsoft/vscode
5 participants
@rebornix @isidorn @hediet @andreamah @VSCodeTriageBot