Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brackets in html #173455

Closed
tjy-gitnub opened this issue Feb 5, 2023 · 9 comments · Fixed by #173569
Closed

brackets in html #173455

tjy-gitnub opened this issue Feb 5, 2023 · 9 comments · Fixed by #173569
Assignees
@hediet
Labels
bracket-pair-colorization bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2023

Comments

@tjy-gitnub
Copy link

Type: Bug

In new version,brackets "<" and ">" are highlighted,it's useless and strange.

VS Code version: Code - Insiders 1.76.0-insider (c4a609f, 2023-02-03T05:23:17.202Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes
@tjy-gitnub
Copy link
Author

image

@aeschli aeschli assigned hediet and unassigned aeschli Feb 6, 2023
@lorand-horvath lorand-horvath mentioned this issue Feb 6, 2023
Closed
@lorand-horvath
Copy link

lorand-horvath commented Feb 6, 2023 •
edited

Another issue (probably the same bug) I see is that bracket pairs are being colorized in .txt files as well - they shouldn't be. This is only occurring in Insiders 1.76.0.
Version 1.75 is fine (no colorization).

@hediet hediet mentioned this issue Feb 6, 2023
Merged
hediet added a commit that referenced this issue Feb 6, 2023
@hediet
Fixes #173455
66a698a
@hediet hediet added this to the February 2023 milestone Feb 6, 2023
@hediet hediet added bug Issue identified by VS Code Team member as probable bug bracket-pair-colorization labels Feb 6, 2023
@hediet
Copy link
Member

hediet commented Feb 6, 2023

Thanks for reporting! Should be fixed in tomorrows insider build.
It would be awesome if you could verify the bugfix!

hediet added a commit that referenced this issue Feb 6, 2023
@hediet
Fixes #173455 (#173569)
35f6b55
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 6, 2023
@lorand-horvath
Copy link

@hediet I confirm the issue with bracket colorization seems to be fixed in today's Insiders 1.76. Thanks!

@hediet hediet added the verified Verification succeeded label Feb 7, 2023
@lorand-horvath lorand-horvath mentioned this issue Feb 7, 2023
Closed
7 tasks
@tjy-gitnub
Copy link
Author

yes,the brackets' color in html is back to normal,
but, why are others without colors?
image
image
(-_-?||

@hediet
Copy link
Member

hediet commented Feb 8, 2023

@tjy-gitnub which version of vscode do you use? And which language is that? Can you check your settings?

@lorand-horvath
Copy link

@hediet I think @tjy-gitnub is working with JS, most probably this snippet from one of his repos: https://github.com/tjy-gitnub/win12/blob/main/sw.js#L61
Could it be caused by the language being used in that file (chinese)? Strange, nonetheless.

@tjy-gitnub
Copy link
Author

No only in js but others
Do yours have the same problem
image

It may be my personal problem...

@blaise80
Copy link

blaise80 commented Feb 9, 2023 via email

c-claeys pushed a commit to c-claeys/vscode that referenced this issue Feb 16, 2023
@hediet @c-claeys
Fixes microsoft#173455 (microsoft#173569)
ef158e6
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bracket-pair-colorization bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

Fixes #173455 microsoft/vscode
6 participants
@hediet @aeschli @blaise80 @tjy-gitnub @lorand-horvath @VSCodeTriageBot