Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll hijacked on notebook cell text selection #173982

Closed
JacksonKearl opened this issue Feb 9, 2023 · 4 comments
Closed

Scroll hijacked on notebook cell text selection #173982

JacksonKearl opened this issue Feb 9, 2023 · 4 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-cell-editor Bugs related to code editors in Notebooks (not intellisense / LS's) verified Verification succeeded
Milestone
February 2023

Comments

@JacksonKearl
Copy link
Contributor

New in v1.75 as far as I can tell. Scroll gets reset to the top of the selection when shift-clicking on a location far enough down that the top of the selection goes out of view. See how when I'm attempting to incrementally add more code to the selection I have to re-scroll to my old position each click. First example in recording is 1.74, next is 1.75.

Recording 2023-02-09 at 11 00 26

Only happens in notebooks, but all notebook I tested are affected (including the the builtin Jupyter one).
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-cell-editor Bugs related to code editors in Notebooks (not intellisense / LS's) labels Feb 10, 2023
@rebornix
Copy link
Member

@JacksonKearl thanks for the report man

@rebornix rebornix added this to the February 2023 milestone Feb 10, 2023
@JacksonKearl
Copy link
Contributor Author

Thanks for the product! :)

rebornix added a commit that referenced this issue Feb 17, 2023
@rebornix
Fix #173982. Respect selection direction in cell reveal.
d5f2b66
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 17, 2023
@JacksonKearl
Copy link
Contributor Author

Verified!

@jrieken jrieken added the verified Verification succeeded label Feb 22, 2023
@jrieken
Copy link
Member

jrieken commented Feb 22, 2023

Marking as verified based on @JacksonKearl comment above

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-cell-editor Bugs related to code editors in Notebooks (not intellisense / LS's) verified Verification succeeded
Projects
None yet
Milestone
February 2023
Development

No branches or pull requests
4 participants
@rebornix @jrieken @JacksonKearl @VSCodeTriageBot