Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test Timeout: ExtensionEnablementService Test #173986

Closed
alexdima opened this issue Feb 9, 2023 · 1 comment · Fixed by #174599
Closed

Unit Test Timeout: ExtensionEnablementService Test #173986

alexdima opened this issue Feb 9, 2023 · 1 comment · Fixed by #174599
Assignees
@sandy081
Labels
insiders-released Patch has been released in VS Code Insiders unit-test-failure
Milestone
February 2023

Comments

@alexdima
Copy link
Member

alexdima commented Feb 9, 2023

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=202792&view=logs&j=55ac390b-ffb1-50ea-3650-525dd9a3fd80&t=3a692518-c3cf-5f6a-c273-72f71dc185fb&l=10326

  8535 passing (2m)
  55 pending
  1 failing

  1) ExtensionEnablementService Test
       "before each" hook for "test enable an extension globally return truthy promise":

      
      + expected - actual


  Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
@sandy081
Copy link
Member

I really do not have any clue why this is failing. It would be great if the error stack provides info where the execution hangs. Anyway, I changed the format of the test to use async and also the check slightly.

sandy081 added a commit that referenced this issue Feb 16, 2023
@sandy081
fix #173986
2f432cf
@sandy081 sandy081 mentioned this issue Feb 16, 2023
Merged
sandy081 added a commit that referenced this issue Feb 16, 2023
@sandy081
fix #173986 (#174599)
3bc8407
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 16, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the February 2023 milestone Feb 16, 2023
c-claeys pushed a commit to c-claeys/vscode that referenced this issue Feb 16, 2023
@sandy081 @c-claeys
fix microsoft#173986 (microsoft#174599)
ef0de55
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
insiders-released Patch has been released in VS Code Insiders unit-test-failure
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

fix #173986 microsoft/vscode
3 participants
@alexdima @sandy081 @VSCodeTriageBot