Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editors opened from the menu bar should not open in preview mode #17431

Closed
kieferrm opened this issue Dec 16, 2016 · 1 comment
Closed

Editors opened from the menu bar should not open in preview mode #17431

kieferrm opened this issue Dec 16, 2016 · 1 comment
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues verified Verification succeeded
Milestone
January 2017

Comments

@kieferrm
Copy link
Member

kieferrm commented Dec 16, 2016 •
edited

Steps to Reproduce:

  1. From menu... File / Preferences / Workplace Settings
  2. From menu... Help / Release Notes
    -> Settings are closed

Editors opened from the menu bar should not open in preview mode so that they stay open.

See also #17428.
@kieferrm kieferrm mentioned this issue Dec 16, 2016
Closed
@bpasero bpasero assigned sandy081 and unassigned bpasero Dec 17, 2016
@bpasero
Copy link
Member

bpasero commented Dec 17, 2016

That is true and I think we used to open them pinned before but we no longer do. Moving to @sandy081, settings and keybindings I argue should all open pinned.

@bpasero bpasero added the config VS Code configuration, set up issues label Dec 17, 2016
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug workbench labels Dec 19, 2016
@sandy081 sandy081 added this to the January 2017 milestone Dec 19, 2016
@jrieken jrieken added the verified Verification succeeded label Jan 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues verified Verification succeeded
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
4 participants
@bpasero @jrieken @kieferrm @sandy081