Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About dialog doesn't get custom dialog style #174914

Closed
alexr00 opened this issue Feb 21, 2023 · 1 comment
Closed

About dialog doesn't get custom dialog style #174914

alexr00 opened this issue Feb 21, 2023 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug dialogs Issues with native and custom dialogs insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2023

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 21, 2023

Testing #174784

  1. Set "window.dialogStyle": "custom"
  2. Help -> About
  3. The about dialog opens, but it's a native dialog.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug dialogs Issues with native and custom dialogs labels Feb 21, 2023
@bpasero bpasero added this to the February 2023 milestone Feb 21, 2023
@bpasero
Copy link
Member

bpasero commented Feb 21, 2023

Nice find!

bpasero added a commit that referenced this issue Feb 21, 2023
@bpasero
About dialog doesn't get custom dialog style (fix #174914)
1722ad9
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 21, 2023
@alexr00 alexr00 added the verified Verification succeeded label Feb 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug dialogs Issues with native and custom dialogs insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2023
Development

No branches or pull requests
4 participants
@bpasero @alexr00 @VSCodeTriageBot and others