Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSServer logs not being created in Insiders #175172

Closed
DanielRosenwasser opened this issue Feb 22, 2023 · 0 comments · Fixed by #175600
Closed

TSServer logs not being created in Insiders #175172

DanielRosenwasser opened this issue Feb 22, 2023 · 0 comments · Fixed by #175600
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded windows VS Code on Windows issues
Milestone
February 2023

Comments

@DanielRosenwasser
Copy link
Member

Version: 1.76.0-insider (user setup)
Commit: 7b6b686
Date: 2023-02-22T05:24:32.270Z
Electron: 19.1.10
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

When I open a .js or .ts file, if I try running TypeScript: Open TS Server Log from the command palette, nothing happens.

Upon further inspection, if I check my server trace, the log file seems to not exist at all - however, the actual directory structure is still present.

image

I seem to have no issues with VS Code stable, or VS Code on the web.

(CC @mjbvz)
@mjbvz mjbvz self-assigned this Feb 22, 2023
@mjbvz mjbvz added this to the March 2023 milestone Feb 27, 2023
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Feb 27, 2023
@mjbvz mjbvz modified the milestones: March 2023, February 2023 Feb 28, 2023
@mjbvz mjbvz added the windows VS Code on Windows issues label Feb 28, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue Feb 28, 2023
@mjbvz
Fix TS Server logging on windows
1cd3863 
Fixes microsoft#175172

We need to pass TS the windows style path here
@mjbvz mjbvz mentioned this issue Feb 28, 2023
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Feb 28, 2023
@mjbvz
Fix TS Server logging on windows
4b0586c 
For microsoft#175172
Ports microsoft#175600 to the 1.76 branch

We need to pass TS the windows style path here instead of the unix style path
@mjbvz mjbvz mentioned this issue Feb 28, 2023
Merged
@jrieken jrieken closed this as completed Feb 28, 2023
@sbatten sbatten added the verified Verification succeeded label Feb 28, 2023
mjbvz added a commit that referenced this issue Feb 28, 2023
@mjbvz
Fix TS Server logging on windows (#175600)
28d9a83 
Fixes #175172

We need to pass TS the windows style path here
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

Fix TS Server logging on windows mjbvz/vscode
4 participants
@DanielRosenwasser @jrieken @sbatten @mjbvz