Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot focus the accessible buffer after the first time #178253

Closed
meganrogge opened this issue Mar 24, 2023 · 4 comments · Fixed by #178280
Closed

Cannot focus the accessible buffer after the first time #178253

meganrogge opened this issue Mar 24, 2023 · 4 comments · Fixed by #178280
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode verified Verification succeeded
Milestone
April 2023

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Mar 24, 2023 •
edited

Using shift+tab here, I cannot enter the accessible buffer

tab-trap.mov
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode labels Mar 24, 2023
@meganrogge meganrogge added this to the April 2023 milestone Mar 24, 2023
@meganrogge
Copy link
Contributor Author

meganrogge commented Mar 24, 2023 •
edited

The issue is that here, the default tab behavior is to focus the terminal tabs element

https://github.com/microsoft/vscode/pull/178021/files#diff-aa9fea5795716c729de5b5e0f9a4644c9ae3d57e87d8a9fa9f28dd7e0db343a2R101-R105

edit:

hard to repro, that's not the cause

meganrogge added a commit that referenced this issue Mar 24, 2023
@meganrogge
fix #178253
0632baf
@meganrogge meganrogge mentioned this issue Mar 24, 2023
Closed
@meganrogge
Copy link
Contributor Author

ok this happens when hide is not applied to xterm.

See here that the buffer editor does get focused here, but you cannot see it

active.mov

@meganrogge
Copy link
Contributor Author

Repro:

  • run some commands
  • Cmd/Ctrl+shift+o
  • Escape
  • Shift+tab
  • Cmd/Ctrl+shift+o
  • Escape
  • Tab
  • Try to Shift+tab 🐛 hide wasn't applied to xterm so the accessible buffer isn't visible

@meganrogge
Copy link
Contributor Author

repro.mov

meganrogge added a commit that referenced this issue Mar 24, 2023
@meganrogge
fix #178253
a35b4b7
@meganrogge meganrogge mentioned this issue Mar 24, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 24, 2023
meganrogge added a commit that referenced this issue Mar 27, 2023
@meganrogge
fix #178253
e813d20
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 30, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode verified Verification succeeded
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

Accessible buffer cleanup part 1 microsoft/vscode
fix tab focus issue microsoft/vscode
4 participants
@Tyriar @rzhao271 @meganrogge @VSCodeTriageBot