Investigate and Improve Key bindings customisations experience #18095

sandy081 · 2017-01-04T10:37:26Z

Investigate and improve key bindings customisations experience.

Following are the proposals, use cases, challenges in this area

Keybindings view

A table based view, each row for each key binding

Key	Command	When	Action
alt+cmd+[	editor.fold	editorTextFocus	Unbind
alt+cmd+]	editor.unfoldRecursively	editorTextFocus	Unbind
Bind	workbench.action.reloadWindow		Bind

Show the correct Keybindings based on the keyboard layout (both defaults and user)

Currently, keybindings show the keys those were shown in the US Keyboard. Since the keys location changes with Keyboard layout, some of the Keybindings shown as is in the file do not work. For eg:
ctrl+` does not work on German layout key board. Instead the associated Keybinding for this is ctrl+<

Show the invalid Keybindings

Some key bindings might not makes sense in some keyboard layouts since . Show such keybindings as unbound entries, probably with message?

Grouping

Group key bindings by VS code core and each extension key bindings

Command id vs title

Show just title or just id or both for the command column? Not all commands have labels and not all command ids are straight to interpret what action they perform. Not all command ids maps well with labels.

When context

when is a combination of the location in VS Code where key binding is applied to and the pre-condition to be met to trigger the action. Not all commands have proper separation of location and precondition. Also some commands have multiple locations. How to render this when clause? How to let user edit this?

Command args

args How to display args

Bound and unbound commands

Display bound and unbound commands as two different groups

As a user, I would like to associate a Keybinding to a command/action

User should be able to find an action say in Keybindings editor or Command Pallette and associate a key binding to it. Use the widget Define Keybinding to record the Key bindings instead of writing it by hand.

An action next to command pallette list entry to bind/unbind the key binding?

As a user, I would like to find the command/action for a Keybinding.

User should be able to find the Keybinding in Keybindings editor and see the associated commands/actions to it.

As a sophisticated user, I would like to switch to native old keybindings json from the new editor

The text was updated successfully, but these errors were encountered:

sgtoj · 2017-03-16T11:10:14Z

@sandy081 Insider build has been my daily driver since its inception; as well as Windows Insiders.

Anyways, I checked it out the keybinding editor view in today's build. It looks great!

sgtoj · 2017-03-16T11:14:49Z

@sandy081 If I can make two suggestions...

Show user overrides at the top.
- Maybe even separate them with a small gap and heading.
Provide a way to easily identify if a default keybinding has been replaced.

edit:

The terminal view covers the keybindings at the bottom of the list. I believe this may be a bug because its behavior is not consistent with the rest of the editor.

sandy081 · 2017-03-16T12:41:54Z

@sgtoj Thanks for the feedback.

The design of this editor is to be simple and show the available Keybindings in the system. Source column was added to help user to show where a particular keybinding is coming from.

To separate User and Default keybindings was one of the initial designs. But as a first cut and with some initial feedback, above simple design was chosen.

I will gather all the feedback and update/improve the design.

Yes, terminal view covering the keybindings is a bug and I will fix it today and you can get it in tomorrows insiders.

Thanks

- Reuse define keybindings widget

schmuli · 2017-03-16T19:14:45Z

@sandy081 further to @sgtoj's comment, I've noticed that even when there is no lower panel open, the bottom of the editor is below the bottom of the screen.

- Use List widget to render keybindings

- Open default keybindings while opening keybindings file like before

- Define keybinding action with keyboard shortcut - Search keybindings action with keyboard shortcut

- Register keybinding for remove action - Make other actions as just keybinding actions

- Down arrow to navigate from search to list

- Do not navigate by Enter from search box

Tekbr · 2017-03-17T12:56:37Z

-- Sorry for the English, I used Google Translator --

@sandy081 The new Keybindings screen would be possible or feasible, allow search not only for the column 'command', but also for the column 'Keybinding' and 'When'?

Why this? VSCode is not yet in my language, and searching for the shortcut key may be faster in this case.

I know we still have the old screen.

sandy081 · 2017-03-17T14:52:19Z

@Tekbr Searching for keybindings is possible. Typing control+w would look for such keybindings. Let me know if it is not working for you. Thanks.

Tekbr · 2017-03-17T16:44:17Z

@sandy081 Oh, I was typing ctrl instead of control. That was my mistake. Why not type Ctrl + anything or instead of Control + anything?

sandy081 · 2017-03-17T17:04:51Z

I will be improving Search to accept both full or short forms

Tekbr · 2017-03-17T18:42:49Z

OK. Thanks for the quick response.

pixieaka · 2017-03-23T01:14:03Z

The interface frozen here #23039

…keybindings editor

- Test to remove last item in the array if there is a comment in the beginning

- Fix remove last item from the array if there is a comment in the beginning

Tekbr · 2017-03-29T11:49:43Z

@sandy081

-- Sorry for the English, I used Google Translator --

I do not know if it's in a commit that was not made available in Insiders.

But in 1.11.0 - Insiders d98a518 2017-03-29T06: 11: 14.271Z, I can not use Ctrl instead of using Control. Can you check it please?

And not forgetting, thanks for allowing you to search the 'When' column. 😄 👍

sandy081 · 2017-03-29T12:18:27Z

@Tekbr This is not yet supported. Please follow the issue #23368.

- Opening keybindings - While performing actions

sandy081 added plan-item VS Code - planned item for upcoming workbench labels Jan 4, 2017

sandy081 self-assigned this Jan 4, 2017

sandy081 added this to the January 2017 milestone Jan 4, 2017

egamma mentioned this issue Jan 4, 2017

January Iteration Plan #17608

Closed

56 tasks

sandy081 mentioned this issue Jan 20, 2017

Port User Settings functionality to Keyboard Shortcuts #18822

Closed

sandy081 modified the milestones: February 2017, January 2017 Jan 20, 2017

sandy081 modified the milestones: Backlog, February 2017 Feb 21, 2017

sandy081 modified the milestones: March 2017, Backlog Mar 7, 2017

sandy081 assigned alexdima Mar 7, 2017

sandy081 changed the title ~~Investigate and Improve Key bindings customizations experience~~ Investigate and Improve Key bindings customisations experience Mar 7, 2017

sandy081 added the keybindings VS Code keybinding issues label Mar 7, 2017

kieferrm mentioned this issue Mar 7, 2017

March Iteration Plan #21923

Closed

58 tasks

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 Implement first cut of keybindings customisation editor

2e8a9c0

sandy081 mentioned this issue Mar 16, 2017

Use Settings Editor Viewer for Editing Keybindings #22660

Closed

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 Move keybinding editor contributions to preferences

b506b2c

- Reuse define keybindings widget

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 clean up - remove unused files

21552d1

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 Keybindings Editor

1709f8a

- Use List widget to render keybindings

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 Keybindings editor

684d0ad

- Open default keybindings while opening keybindings file like before

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 Keybindings editor

8f5b2f5

- Define keybinding action with keyboard shortcut - Search keybindings action with keyboard shortcut

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 Keybindings editor

1a7b419

- Register keybinding for remove action - Make other actions as just keybinding actions

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 Keybindings editor

905db5d

- Down arrow to navigate from search to list

sandy081 added a commit that referenced this issue Mar 16, 2017

#18095 Keybindings Editor

8584f9d

- Do not navigate by Enter from search box

sandy081 added a commit that referenced this issue Mar 17, 2017

#18095 💄

f3a5403

sandy081 added a commit that referenced this issue Mar 17, 2017

#18095 💄

9d2e061

sandy081 added a commit that referenced this issue Mar 17, 2017

#18095 💄

8d6e85a

sandy081 added a commit that referenced this issue Mar 17, 2017

#18095 Reveal and focus keybinding item after define action

f98c884

sandy081 added a commit that referenced this issue Mar 17, 2017

#18095 Copy action to copy keybinding entry

bd5a257

sandy081 added a commit that referenced this issue Mar 19, 2017

#18095 Use ResolvedKeybindingItem instead of IkeybindingItem2

2a2f3de

sandy081 added a commit that referenced this issue Mar 19, 2017

#18095 Show kyebinding label if has highlights

f51ed6a

sandy081 added a commit that referenced this issue Mar 27, 2017

#18095 - Let match command's default locale label while searching in …

2950906

…keybindings editor

sandy081 added a commit that referenced this issue Mar 27, 2017

#18095 - Improve focussing

6fdf8a1

sandy081 added a commit that referenced this issue Mar 27, 2017

#18095 Json edit

919254b

- Test to remove last item in the array if there is a comment in the beginning

sandy081 added a commit that referenced this issue Mar 27, 2017

#18095 json edit

b7da841

- Fix remove last item from the array if there is a comment in the beginning

sandy081 added a commit that referenced this issue Mar 27, 2017

#18095 Include when and source label in Search

27a53ad

sandy081 added a commit that referenced this issue Mar 27, 2017

#18095 - Check the index before setting the focus

78436d7

sandy081 mentioned this issue Mar 27, 2017

Test Keybindings customisations editor #18095 #23287

Closed

3 tasks

sandy081 closed this as completed Mar 28, 2017

This was referenced Mar 28, 2017

Pressing Cmd in keystroke box always fills in some previous key combination #23365

Closed

Consider to ignore casing when sorting keybindings #23389

Closed

sandy081 added a commit that referenced this issue Mar 31, 2017

#18095 Record telemetery events

5c4a70d

- Opening keybindings - While performing actions

sandy081 added a commit that referenced this issue Mar 31, 2017

#18095 Rename Keybindings title to Keyboard Shortcuts

74481a5

sandy081 added a commit that referenced this issue Mar 31, 2017

#18095 - Remove descriptions from commands as they do not need args

2c2cf0b

vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Investigate and Improve Key bindings customisations experience #18095

Investigate and Improve Key bindings customisations experience #18095

sandy081 commented Jan 4, 2017 •

edited

sgtoj commented Mar 16, 2017

sgtoj commented Mar 16, 2017 •

edited

sandy081 commented Mar 16, 2017

schmuli commented Mar 16, 2017

Tekbr commented Mar 17, 2017

sandy081 commented Mar 17, 2017

Tekbr commented Mar 17, 2017

sandy081 commented Mar 17, 2017

Tekbr commented Mar 17, 2017

pixieaka commented Mar 23, 2017

Tekbr commented Mar 29, 2017

sandy081 commented Mar 29, 2017

Investigate and Improve Key bindings customisations experience #18095

Investigate and Improve Key bindings customisations experience #18095

Comments

sandy081 commented Jan 4, 2017 • edited

Keybindings view

Show the correct Keybindings based on the keyboard layout (both defaults and user)

Show the invalid Keybindings

Grouping

Command id vs title

When context

Command args

Bound and unbound commands

As a user, I would like to associate a Keybinding to a command/action

As a user, I would like to find the command/action for a Keybinding.

As a sophisticated user, I would like to switch to native old keybindings json from the new editor

sgtoj commented Mar 16, 2017

sgtoj commented Mar 16, 2017 • edited

sandy081 commented Mar 16, 2017

schmuli commented Mar 16, 2017

Tekbr commented Mar 17, 2017

sandy081 commented Mar 17, 2017

Tekbr commented Mar 17, 2017

sandy081 commented Mar 17, 2017

Tekbr commented Mar 17, 2017

pixieaka commented Mar 23, 2017

Tekbr commented Mar 29, 2017

sandy081 commented Mar 29, 2017

sandy081 commented Jan 4, 2017 •

edited

sgtoj commented Mar 16, 2017 •

edited