Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread / program do not get focused in the model when clicked in the view #18426

Closed
roblourens opened this issue Jan 12, 2017 · 5 comments
Closed

Thread / program do not get focused in the model when clicked in the view #18426

roblourens opened this issue Jan 12, 2017 · 5 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
January 2018

Comments

@roblourens
Copy link
Member

I would assume that if I pick a different debug target in the call stack, then type something in the console, it would send an evaluateRequest to the selected debug target. But when I press enter, the selection changes to the first target in the call stack, and the request is sent to the first target.
@isidorn isidorn added this to the January 2017 milestone Jan 12, 2017
@isidorn
Copy link
Contributor

isidorn commented Jan 12, 2017

Can not repro.
Every expression I enter in the debug console is sent to the selected stack frame in the call stack.

Can you please provide repro steps or let me know what you are doing different thane me

hmm

@isidorn isidorn added the info-needed Issue requires more information from poster label Jan 12, 2017
@roblourens
Copy link
Member Author

I guess the trick is, this happens when the focused target is not paused:

jan-12-2017 18-35-32

@isidorn isidorn removed the info-needed Issue requires more information from poster label Jan 19, 2017
@isidorn
Copy link
Contributor

isidorn commented Jan 19, 2017

Yes the issue is that currently we do not focus a thread or a process when those are clicked. We only focus when a stack frame gets clicked.
I agree this is not nice, especailly in your use case. Though does not feel critical -> debt week

@isidorn isidorn modified the milestones: February 2017, January 2017 Jan 19, 2017
@isidorn isidorn modified the milestones: March 2017, February 2017 Feb 21, 2017
@isidorn isidorn modified the milestones: Backlog, March 2017 Mar 10, 2017
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues and removed debug-console labels Mar 10, 2017
@isidorn isidorn changed the title Can't select debug target for eval in console Thread / program do not get focused in the model when clicked in the view Nov 13, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 12, 2017

Assigning to December
fyi @weinand

@isidorn isidorn modified the milestones: Backlog, December 2017 Dec 12, 2017
@isidorn isidorn mentioned this issue Dec 12, 2017
Closed
@isidorn isidorn closed this as completed in 935630b Jan 3, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 3, 2018

I have changed how we handle selection changes in the call stack view.
Notice that a click on the thread or process should expand / collapse it. So if a thread / process is not focus it focuses the thread process and expands it. It will only collapse it if it is already focused. Just try it out and let me know how it works for you since I found this behavior quite ok and natural.

fyi @weinand the issues you were facing with your node cluster should be fixed now

@chrmarti chrmarti added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
3 participants
@roblourens @isidorn @chrmarti