Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AccessibleView for hovers #184620

Closed
meganrogge opened this issue Jun 8, 2023 · 12 comments · Fixed by #185614
Closed

Use AccessibleView for hovers #184620

meganrogge opened this issue Jun 8, 2023 · 12 comments · Fixed by #185614
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan
Milestone

Comments

@meganrogge
Copy link
Contributor

          An excellent fix. Works as expected. It would be great if the same could be done for the Show or Focus Hover command.

Originally posted by @jvesouza in #173911 (comment)

@meganrogge meganrogge self-assigned this Jun 8, 2023
@meganrogge meganrogge added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jun 8, 2023
@meganrogge meganrogge added this to the June 2023 milestone Jun 8, 2023
@jvesouza
Copy link

jvesouza commented Jun 9, 2023

I did a quick test and it turned out excellent, exactly as I thought. A small detail is that when I pressed alt+f1 orca read something like terminal accessibility help.

@meganrogge
Copy link
Contributor Author

@jvesouza this has not been implemented yet

meganrogge added a commit that referenced this issue Jun 19, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 20, 2023
@jvesouza
Copy link

Maybe it has nothing to do with the implementation made but I can't access accessibility help anymore.
If I am for example in an editor and I press alt+f1 nothing is announced by orca. The same happens in the terminal and in the chat input.

@meganrogge
Copy link
Contributor Author

meganrogge commented Jun 21, 2023

@jvesouza hm, it's working for me - and you're using the latest insider's, correct? can you try with NVDA?

what happens now for the help menus is they open in a monaco editor. can you tell what element is focused when you use alt+f1?

@jvesouza
Copy link

@jvesouza hm, it's working for me - and you're using the latest insider's, correct? can you try with NVDA?

what happens now for the help menus is they open in a monaco editor. can you tell what element is focused when you use alt+f1?

Yes, I am using The latest insider and I'll try to test using nvda as soon as possible.
However I noticed that the "show accessibility help" command doesn't seem to exist anymore because I press ctrl+shift+p, type "show accessibility help" and I get the information that nothing was found.

@meganrogge
Copy link
Contributor Author

Yeah, that's because it is a multi-command, which doesn't allow it to show up in the quick pick. I'll make an issue for that

@jvesouza
Copy link

I can't tell which element gets the focus when I press alt+f1, but the impression I get is that the focus doesn't change. What leads me to think this is the fact that after pressing alt+f1 if I press down arrow, orca reads the next line in the file being edited.
Something similar happens when I'm in the terminal. If I press alt+f1 and then press up arrow, orca reads the last command executed.

Something that caught my attention is that I found the following in the default key bindingss:

{ "key": "alt+f1",                "command": "editor.action.accessibilityHelp" },
{ "key": "shift+alt+f1",          "command": "editor.action.accessibilityHelp" },
{ "key": "alt+f1",                "command": "editor.action.accessibilityView" },
{ "key": "shift+alt+f1",          "command": "editor.action.accessibilityView" },

Is this right?

@meganrogge
Copy link
Contributor Author

@jvesouza that explains it - the default keybindings are:

{ "key": "alt+f1",                "command": "editor.action.accessibilityHelp" },
{ "key": "alt+f2",                "command": "editor.action.accessibilityView" },

Replacing the above with those should fix it for you

@jvesouza
Copy link

@jvesouza that explains it - the default keybindings are:

{ "key": "alt+f1",                "command": "editor.action.accessibilityHelp" },
{ "key": "alt+f2",                "command": "editor.action.accessibilityView" },

Replacing the above with those should fix it for you

Instead of using the combination alt+f2 I used alt+shift+f1 because alt+f2 is the shortcut used in gnome to activate the command execution dialog.
Once configured, I ran the following tests:

  1. Open the VSCode editor.

  2. Press alt+f1
    The accessibility help for the VSCode editor was displayed, although orca read accessibility help for the terminal. The title seems wrong but the content is correct.

  3. Open the VSCode editor.

  4. Press alt+shift+f1.
    Nothing was read by orca.

I ran the same tests after opening a terminal but nothing was read by orca.

@meganrogge
Copy link
Contributor Author

I would assume the keybinding is not working for some reason in that case. Could you toggle keyboard shortcuts troubleshooting, which will print to the output what might be going on, and share that?

Thanks

@jvesouza
Copy link

jvesouza commented Jul 2, 2023

I would assume the keybinding is not working for some reason in that case. Could you toggle keyboard shortcuts troubleshooting, which will print to the output what might be going on, and share that?

Thanks

I'm sorry I didn't respond sooner, I've had a very difficult and busy week.
In the meantime something seems to have changed as now everything is working as expected.
The exception is the alt+f2 and shift+alt+f2 keys which are probably used by gnome, at least on my machine. I have associated the command assigned to these keys to shift+alt+f1 and it is working ok.
If I still need toggle keyboard shortcuts troubleshooting I will need guidance on how to do it because I honestly don't know the procedure for doing so.
Thanks.

@meganrogge
Copy link
Contributor Author

Sounds like it's now working for you other than the conflict with gnome, so no need to toggle the keyboard troubleshooting

@meganrogge meganrogge added the on-release-notes Issue/pull request mentioned in release notes label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants