Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard: the configure button in the notification pop is not accessible by tab key #184711

Closed
fsteffi opened this issue Jun 9, 2023 · 6 comments
Closed

Keyboard: the configure button in the notification pop is not accessible by tab key #184711

fsteffi opened this issue Jun 9, 2023 · 6 comments
Assignees
@bpasero
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-notifications Notification widget issues
Milestone
June 2023

Comments

@fsteffi
Copy link

fsteffi commented Jun 9, 2023

GitHub Tags:#A11yTCS;#A11y_VSCode;#CAITestPass_May2020; #DesktopApp;#Win11;#MAS2.4.3;#Benchmark;#FTP;#A11yMAS;#A11ySev2;#AINotInScope;#Keyboard;#Visual Studio Code;

Environment Details:

Application Name: Azure Extensions for VS Code
Version: 1.80.0-insider (user setup)
Commit: db6bcdf
Date: 2023-06-09T05:21:13.157Z
Electron: 22.5.5
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.25370
Edition Windows 11 Enterprise
Version 22H2
Installed on ‎29-‎05-‎2023
OS build 25370.1
Experience Windows Feature Experience Pack 1000.25350.1000.0

Repro Steps:

  1. Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility tester after bug verification.
  2. Open Visual studio code
  3. Click on extension button and search for "A11y-kit"
  4. Click on install
  5. run F1 > a11y-kit: Select UI feature for accessibility testing.
  6. click show information messages
  7. Navigate to configure notification button and expand and then collapse with the help of esc key.

Actual:

the configure button the notification is not accessible with tab key.

Expected:

Focus should move to the configure button on tab navigation

User Impact:

User will not be able to open the configure button

Attachment:

Video.6-09.at.15.49.webm
@fsteffi
Copy link
Author

fsteffi commented Jun 9, 2023

logged in ref to bug microsoft/vscode-azurefunctions#3637

@fsteffi fsteffi mentioned this issue Jun 9, 2023
Closed
@lramos15 lramos15 assigned meganrogge and unassigned lramos15 Jun 9, 2023
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jun 12, 2023
@meganrogge
Copy link
Contributor

@bpasero I think making the configure button always visible would fix this. Thoughts?

@bpasero
Copy link
Member

bpasero commented Jun 12, 2023

There is no configure button in all notifications only those that have configure actions. I think for these the button is always visible:

image

What are the exact steps to reproduce here?

@bpasero bpasero added info-needed Issue requires more information from poster workbench-notifications Notification widget issues labels Jun 12, 2023
@fsteffi
Copy link
Author

fsteffi commented Jun 13, 2023

HI @bpasero the button is not always visible hence the issue.

  1. Open Visual studio code
  2. Click on extension button and search for "A11y-kit"
  3. Click on install
  4. run F1 > a11y-kit: Select UI feature for accessibility testing.
  5. click show information messages
  6. Navigate to configure notification button and expand and then collapse with the help of esc key.

bpasero added a commit that referenced this issue Jun 13, 2023
@bpasero
Keyboard: the configure button in the notification pop is not accessi…
52e033b 
…ble by tab key (fix #184711)
@bpasero bpasero removed the info-needed Issue requires more information from poster label Jun 13, 2023
@bpasero bpasero added this to the June 2023 milestone Jun 13, 2023
@bpasero
Copy link
Member

bpasero commented Jun 13, 2023

This is a great finding and I even figured out an issue with notifications in general. The actions in the toolbar are not meant to always show, only when the toast has focus.

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 13, 2023
@fsteffi
Copy link
Author

fsteffi commented Jun 14, 2023

#closed;
Video 6-14 at 16.15.webm

Version: 1.80.0-insider (user setup)
Commit: f3aa9a2
Date: 2023-06-14T09:02:23.566Z
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.25375

@bpasero bpasero added the verified Verification succeeded label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpasero bpasero

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
June 2023
Development

No branches or pull requests
5 participants
@bpasero @lramos15 @fsteffi @meganrogge @VSCodeTriageBot