Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji ascii warning showing up twice #186206

Closed
Tyriar opened this issue Jun 26, 2023 · 1 comment · Fixed by #187985
Closed

Emoji ascii warning showing up twice #186206

Tyriar opened this issue Jun 26, 2023 · 1 comment · Fixed by #187985
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders unicode-highlight verified Verification succeeded
Milestone
July 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2023

Repro:

Open https://insiders.vscode.dev/github/microsoft/vscode-internalbacklog/blob/main/templates/endgame-plan.md
Hover the warning

image
@hediet hediet added bug Issue identified by VS Code Team member as probable bug unicode-highlight labels Jun 26, 2023
@hediet hediet added this to the Backlog milestone Jun 26, 2023
@hediet
Copy link
Member

hediet commented Jun 26, 2023

Monaco editor repro
https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0-dev.20230621#XQAAAAJjAQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzZypW_1uhs0-3YGTBOsVJ4S4FwfCDQb5-2uUHXTVAefbVSd9IzaZ_vv9VR9KugsKixL9jLeD7HHL26qxFDltSgM4yCD-Oxo0Le1R7t_ezMZs4Fqbwf2LLftlGDbVC0pzlSC0FKh_zxEB2PYU8mnloEYCRxBUCirzPZl-pNGYPkUzLUS30fWAevSH-YVy8w-ajItWMcFieVh3ABCemhcYdAR5_CQZMEToq6B5ANZWC7FKaenDFFIJTbFnggipMs1JRuN612Pva9BBI9vxuZ-HELRkWd7_Uk0jdXWCIIsNrZFJ_-BvI2A

yshaojun added a commit to yshaojun/vscode that referenced this issue Jul 15, 2023
@yshaojun
fix: prevent duplicate reason(microsoft#186206)
dd6af83
@yshaojun yshaojun mentioned this issue Jul 15, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 17, 2023
hediet added a commit that referenced this issue Jul 17, 2023
@hediet
Merge pull request #187985 from yshaojun/fix/186206
e529771 
fix: prevent duplicate reason(#186206)
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 18, 2023
@andreamah andreamah modified the milestones: Backlog, July 2023 Jul 24, 2023
@Tyriar Tyriar added the verified Verification succeeded label Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders unicode-highlight verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

fix: prevent duplicate reason(#186206) yshaojun/vscode
4 participants
@Tyriar @hediet @andreamah @VSCodeTriageBot