Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff Editor - editor side context key issue #186335

Closed
lszomoru opened this issue Jun 27, 2023 · 0 comments · Fixed by #186997
Closed

Diff Editor - editor side context key issue #186335

lszomoru opened this issue Jun 27, 2023 · 0 comments · Fixed by #186997
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
July 2023

Comments

@lszomoru
Copy link
Member

lszomoru commented Jun 27, 2023 •
edited by hediet

Testing #186213

This is an issue that was present in the previous editor but it would be great to fix.

  • Open a folder/workspace that contains a git repository
  • Make changes to a file so that the change appears in the Source Control view
  • Click on the change so that it is opened in the diff editor
  • Left-click on the right side of the editor
  • Right-click on the right side of the editor and notice the (Stage | Unstage | Revert) Selected Ranges commands
  • Right-click on the left side of the editor and notice the commands there as well
  • Close the context menu, and right-click again on the left side. Commands are not there.

The problem is that at the moment the editor side context key is updated on focus/blur instead of using a context key service that is scoped to an HTML element.

Edit from @hediet: This only reproduces on Mac.
@lszomoru lszomoru changed the title Diff Editor - side context key issue Diff Editor - editor side context key issue Jun 27, 2023
@hediet hediet added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues labels Jun 28, 2023
@hediet hediet added this to the July 2023 milestone Jun 28, 2023
@hediet hediet mentioned this issue Jul 4, 2023
Merged
hediet added a commit that referenced this issue Jul 4, 2023
@hediet
Fixes #186335
d82bc8f
hediet added a commit that referenced this issue Jul 4, 2023
@hediet
Fixes #186335 (#186997)
854108f
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 4, 2023
@rzhao271 rzhao271 added the macos Issues with VS Code on MAC/OS X label Jul 27, 2023
@sandy081 sandy081 added the verified Verification succeeded label Jul 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Fixes #186335 microsoft/vscode
5 participants
@hediet @lszomoru @rzhao271 @sandy081 @VSCodeTriageBot