Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine message about settings to also include keybinding customization #186354

Closed
jrieken opened this issue Jun 27, 2023 · 1 comment · Fixed by #186492
Closed

Refine message about settings to also include keybinding customization #186354

jrieken opened this issue Jun 27, 2023 · 1 comment · Fixed by #186492
Assignees
@sandy081
Labels
insiders-released Patch has been released in VS Code Insiders issue-reporter Issue reporter widget issues polish Cleanup and polish issue
Milestone
June 2023

Comments

@jrieken
Copy link
Member

jrieken commented Jun 27, 2023

Testing #186171

When there is a customization issue the message in the issue reporter just says

"> Issue troubleshooting has identified that the issue is caused by your settings. Please report the issue by sharing your settings. "

This should be refined to also mention keybindings because AFAIK they are in the same bucket of enabled/disabled by profile
@sandy081 sandy081 added polish Cleanup and polish issue issue-reporter Issue reporter widget issues labels Jun 27, 2023
@sandy081 sandy081 added this to the June 2023 milestone Jun 27, 2023
@sandy081
Copy link
Member

I think Snippets & Tasks also fall in this category. Probably sharing the profile is the right approach.

@sandy081 sandy081 mentioned this issue Jun 28, 2023
Merged
sandy081 added a commit that referenced this issue Jun 28, 2023
@sandy081
Fix #186354
d4bce45
sandy081 added a commit that referenced this issue Jun 28, 2023
@sandy081
Fix #186354 (#186492)
eefab14
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
insiders-released Patch has been released in VS Code Insiders issue-reporter Issue reporter widget issues polish Cleanup and polish issue
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

Fix #186354 microsoft/vscode
3 participants
@jrieken @sandy081 @VSCodeTriageBot