-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NotebookEditor.layout()
throws: TypeError: Cannot read properties of undefined (reading 'size')
#186394
Comments
@joaomoreno I assigned you for grid layout and @bpasero I assigned you for editor layout, please feel free to unassign if this isn't relevant to you |
screen.cheese.mp4 |
@joyceerhl empty editor groups are not a bug per-se, if you configure However, the fact that you cannot get rid of the empty group when you press the X button sounds like an issue to me. When you try to close, is there anything printed to the console? |
Ohhhhhhhhhhh good bug! 👏 There is definitely splitview/gridview breakage here. |
Wait. I could repro once... but not anymore. @joyceerhl Can you still repro? |
Yes I reproed twice |
@bpasero I cannot see anything in logs when clicking on the X unfortunately (fwiw, I do not have that setting configured) When I repro this, here's what's in the log (this happens right after closing the last editor in a group that results in the group not also being closed)
|
@joaomoreno I wonder if this could possibly be a regression from the auto-sizing feature you did? |
We just need to be able to repro on demand so we can attempt to repro on a version before my changes to confirm this. But I can't seem to repro no more. 😢 Can you @bpasero ? |
I cannot reproduce this, I never get an empty editor group. This is with fresh user data dir and extensions dir. |
@joyceerhl if you have a reliable repro that you can share, including your settings if any. Here is what I do: |
OK, I have a trivial and consistent repro. TLDR it looks like the interactive window does not play nice with split view.
splitview.mp4Logs
|
This also repros for notebooks opened in the second group |
Oh wow. So it looks like the call to
|
NotebookEditor.layout()
throws: TypeError: Cannot read properties of undefined (reading 'size')
#186557 for surrounding some of the calls with |
Arguably, the grid/splitview should also protect itself... 🤔 |
Yeah, maybe. There could be other cases. |
I can't repro any of these now but it would probably help for @joyceerhl to verify too |
I still do not have a functional cursor/trackpad so cannot drag/drop 🫠 @rebornix maybe you can verify? |
Verified it's working great |
Testing #186191
The text was updated successfully, but these errors were encountered: