Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffs For Deleted Files Is Not Great #186648

Closed
hediet opened this issue Jun 29, 2023 · 1 comment · Fixed by #186994
Closed

Diffs For Deleted Files Is Not Great #186648

hediet opened this issue Jun 29, 2023 · 1 comment · Fixed by #186994
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2023

Comments

@hediet
Copy link
Member

hediet commented Jun 29, 2023 •
edited

Repro (verify in latest dev release)

chrome_MNbMaDZTMM
@hediet hediet added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues labels Jun 29, 2023
@hediet hediet added this to the July 2023 milestone Jun 29, 2023
@hediet hediet self-assigned this Jun 29, 2023
@hediet hediet mentioned this issue Jul 4, 2023
Merged
hediet added a commit that referenced this issue Jul 4, 2023
@hediet
Fixes #186648
bcfaffd
hediet added a commit that referenced this issue Jul 4, 2023
@hediet
Fixes #186648 (#186994)
dca4956
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 4, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Jul 26, 2023
@joyceerhl
Copy link
Contributor

This is what I see now (playground link)

image

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Fixes #186648 microsoft/vscode
3 participants
@hediet @joyceerhl @VSCodeTriageBot