Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Heuristic Tokenization Has Delay #187063

Closed
hediet opened this issue Jul 5, 2023 · 0 comments · Fixed by #187692
Closed

Initial Heuristic Tokenization Has Delay #187063

hediet opened this issue Jul 5, 2023 · 0 comments · Fixed by #187692
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tokenization Text tokenization verified Verification succeeded
Milestone
July 2023

Comments

@hediet
Copy link
Member

hediet commented Jul 5, 2023 •
edited

This only happens for models that don't restore view state: (notice that at first all the text is black on white)

Code_-_Insiders_nIfQFsIY4g

This bug is caused by the missing signal that the view state stabilized.

Verify that there is no flickering now:

Code_-_OSS_iglMYzToFz
@hediet hediet added bug Issue identified by VS Code Team member as probable bug tokenization Text tokenization labels Jul 5, 2023
@hediet hediet added this to the July 2023 milestone Jul 5, 2023
@hediet hediet self-assigned this Jul 5, 2023
@hediet hediet mentioned this issue Jul 12, 2023
Merged
hediet added a commit that referenced this issue Jul 12, 2023
@hediet
Fixes #187063
e9f17a5
hediet added a commit that referenced this issue Jul 12, 2023
@hediet
Merge pull request #187692 from microsoft/hediet/b/cool-wolverine
ba8caef 
Fixes #187063
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 12, 2023
@mjbvz mjbvz added the verified Verification succeeded label Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tokenization Text tokenization verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Fixes #187063 microsoft/vscode
3 participants
@hediet @mjbvz @VSCodeTriageBot