Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff Editor: New Files Have Weird Alignments #187939

Closed
hediet opened this issue Jul 14, 2023 · 1 comment · Fixed by #188504
Closed

Diff Editor: New Files Have Weird Alignments #187939

hediet opened this issue Jul 14, 2023 · 1 comment · Fixed by #188504
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2023

Comments

@hediet
Copy link
Member

hediet commented Jul 14, 2023

repro
@hediet hediet added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues labels Jul 14, 2023
@hediet hediet added this to the July 2023 milestone Jul 14, 2023
@hediet hediet self-assigned this Jul 14, 2023
yshaojun added a commit to yshaojun/vscode that referenced this issue Jul 19, 2023
@yshaojun
fix: line number exclusive(microsoft#187939)
7d0d041
@yshaojun yshaojun mentioned this issue Jul 19, 2023
Closed
@hediet hediet mentioned this issue Jul 21, 2023
Merged
hediet added a commit that referenced this issue Jul 21, 2023
@hediet
Fixes #187939
ad30767
hediet added a commit that referenced this issue Jul 21, 2023
@hediet
Fixes #187939 (#188504)
698b8ad
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 21, 2023
@rzhao271
Copy link
Contributor

The issue still occurs in Monaco Editor v0.41.0-dev.20230719, but it seems to be fixed in VS Code Insiders. I'll add the verified label for now, but feel free to mark that as verification-found if it indicates there's a bug still.

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Fixes #187939 microsoft/vscode
fix: line number exclusive(#187939) yshaojun/vscode
3 participants
@hediet @rzhao271 @VSCodeTriageBot