Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings sync installs extensions which need to be migrated #187947

Closed
joyceerhl opened this issue Jul 14, 2023 · 4 comments 路 Fixed by #188529
Closed

Settings sync installs extensions which need to be migrated #187947

joyceerhl opened this issue Jul 14, 2023 · 4 comments 路 Fixed by #188529
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-sync verified Verification succeeded
Milestone
July 2023

Comments

@joyceerhl
Copy link
Contributor

  1. Have GitHub Copilot Nightly synced to settings sync
  2. Create a codespace
  3. 馃悰 Copilot prerelease is installed and I get this notification
image
@joyceerhl joyceerhl changed the title Settings sync installs deprecated extensions Settings sync installs extensions which need to be migrated Jul 14, 2023
@sandy081
Copy link
Member

Copilot prerelease is installed and I get this notification

Do you mean Copilot nightly is installed?

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug settings-sync labels Jul 17, 2023
@sandy081 sandy081 added this to the July 2023 milestone Jul 17, 2023
@joyceerhl
Copy link
Contributor Author

Yeah, I'm guessing first I get Copilot nightly, then it gets uninstalled in favor of Copilot prerelease because of the migration code

@sandy081
Copy link
Member

then it gets uninstalled in favor of Copilot prerelease because of the migration code

So this should remove the nightly extension from your synced data right?

@joyceerhl
Copy link
Contributor Author

Not if the codespace only has read access to settings sync (which I believe is the default)

@sandy081 sandy081 mentioned this issue Jul 21, 2023
Merged
sandy081 added a commit that referenced this issue Jul 21, 2023
@sandy081
fix #187947
6cf6e2b
sandy081 added a commit that referenced this issue Jul 21, 2023
@sandy081
fix #187947 (#188529)
5a04b14
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 21, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Jul 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-sync verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

fix #187947 microsoft/vscode
3 participants
@sandy081 @joyceerhl @VSCodeTriageBot