Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing extension from VSIX after installing from location deletes original directory #188582

Closed
eeroel opened this issue Jul 22, 2023 · 2 comments · Fixed by #188917 or #190957
Closed

Installing extension from VSIX after installing from location deletes original directory #188582

eeroel opened this issue Jul 22, 2023 · 2 comments · Fixed by #188917 or #190957
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
August 2023

Comments

@eeroel
Copy link

eeroel commented Jul 22, 2023

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.80.1
  • OS Version: Mac OS 13.4.1

Steps to Reproduce:

  1. Set up extension
  2. Use Developer: Install Extension From Location to install the extension from the root path of the extension (the one with package.json etc)
  3. Package the extension into vsix
  4. Use Developer: Install Extension From VSIX and select the newly created vsix (this file can be anywhere)
  5. The extension directory gets deleted
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Jul 26, 2023
@sandy081 sandy081 added this to the July 2023 milestone Jul 26, 2023
@sandy081 sandy081 mentioned this issue Jul 26, 2023
Merged
sandy081 added a commit that referenced this issue Jul 26, 2023
@sandy081
fix #188582
12e03ad
sandy081 added a commit that referenced this issue Jul 26, 2023
@sandy081
fix #188582 (#188917)
0b58930
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 26, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Jul 27, 2023
@gjsjohnmurray gjsjohnmurray mentioned this issue Jul 31, 2023
Closed
@alexr00 alexr00 mentioned this issue Aug 9, 2023
Merged
@sandy081 sandy081 modified the milestones: July 2023, August 2023 Aug 21, 2023
@sandy081 sandy081 removed verified Verification succeeded insiders-released Patch has been released in VS Code Insiders labels Aug 21, 2023
@sandy081 sandy081 reopened this Aug 21, 2023
@sandy081
Copy link
Member

This is not fixed completely after reverting the fix (#190074).

Hence reopened it.

@sandy081 sandy081 mentioned this issue Aug 22, 2023
Merged
sandy081 added a commit that referenced this issue Aug 22, 2023
@sandy081
fix #188582
a4481ab
@sandy081
Copy link
Member

  1. Set up extension
  2. Use Developer: Install Extension From Location to install the extension from the root path of the extension (the one with package.json etc)
  3. Open extensions.json file from extensions installation folder (Use command F1> Open Extensions Folder) and make sure the installed extension location is the location of the extension.
  4. Package the extension into a vsix and move the VSIX to a location other than the extension location.
  5. Use Developer: Install Extension From VSIX and select the newly created vsix
  6. Open extensions.json file from extensions installation folder (Use command F1> Open Extensions Folder) and make sure the installed extension location is the location of the extracted VSIX in the extensions installation folder.
  7. Restart VS Code and make sure source location of the extension in the disk is not deleted.

sandy081 added a commit that referenced this issue Aug 22, 2023
@sandy081
fix #188582 (#190957)
d8affc0
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 22, 2023
@sandy081 sandy081 mentioned this issue Aug 30, 2023
Closed
@connor4312 connor4312 added the verified Verification succeeded label Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

fix #188582 microsoft/vscode
fix #188582 microsoft/vscode
5 participants
@connor4312 @eeroel @sandy081 @joyceerhl @VSCodeTriageBot