Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WelcomeUX] Checkbox should be aligned with text #18879

Closed
Tyriar opened this issue Jan 20, 2017 · 10 comments
Closed

[WelcomeUX] Checkbox should be aligned with text #18879

Tyriar opened this issue Jan 20, 2017 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities workbench-welcome Welcome page issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 20, 2017

Testing #18091

image

@bgashler1
Copy link
Contributor

This doesn't seem to be an issue now that the serif font bug is gone.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 20, 2017

@bgashler1 I saw this on Linux, I couldn't see styles that made an effort to align so it could differ between platforms.

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2017
@chrmarti chrmarti added this to the January 2017 milestone Jan 25, 2017
@ramya-rao-a
Copy link
Contributor

Still an issue in Windows, not so much in Mac

image

@ramya-rao-a ramya-rao-a reopened this Jan 25, 2017
@chrmarti chrmarti added the candidate Issue identified as probable candidate for fixing in the next release label Jan 26, 2017
@bpasero
Copy link
Member

bpasero commented Jan 27, 2017

Not aligned on Windows:

image

@chrmarti try playing around with line-height on the parent div, e.g. 20px gives me this (but needs verification across OS):

image

@bpasero bpasero reopened this Jan 27, 2017
@bpasero bpasero modified the milestones: February 2017, January 2017 Jan 27, 2017
@bpasero bpasero added the verification-found Issue verification failed label Jan 27, 2017
@chrmarti chrmarti removed candidate Issue identified as probable candidate for fixing in the next release verification-found Issue verification failed labels Jan 27, 2017
@chrmarti
Copy link
Contributor

On OSX:

1.9:
screen shot 2017-01-30 at 1 45 29 pm

With line-height 20px on parent:
screen shot 2017-01-30 at 1 47 16 pm

With line-height 18px on parent:
screen shot 2017-01-30 at 1 49 29 pm

One would think there must be a canonical way of doing this, but I haven't found one yet.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 31, 2017

This seems to do the trick, looks right on Windows at least http://stackoverflow.com/a/719545/1156119

input[type=checkbox] {
  vertical-align: middle;
  position: relative;
  bottom: 1px;
}

Could also try this one which has the most votes: http://stackoverflow.com/a/306593/1156119

@chrmarti chrmarti removed this from the February 2017 milestone Feb 3, 2017
@bpasero bpasero added workbench-welcome Welcome page issues and removed workbench labels Nov 16, 2017
@chrmarti chrmarti added the *out-of-scope Posted issue is not in scope of VS Code label Oct 2, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 2, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 2, 2018
@Tyriar Tyriar removed the *out-of-scope Posted issue is not in scope of VS Code label Oct 2, 2018
@Tyriar Tyriar self-assigned this Oct 2, 2018
@Tyriar Tyriar reopened this Oct 2, 2018
@Tyriar Tyriar added this to the October 2018 milestone Oct 2, 2018
@Tyriar Tyriar closed this as completed in 686e741 Oct 2, 2018
@chrmarti chrmarti removed their assignment Oct 3, 2018
@chrmarti
Copy link
Contributor

chrmarti commented Oct 3, 2018

Thanks @Tyriar for looking into it. Unfortunately this doesn't work well on Mac:
image

@chrmarti chrmarti reopened this Oct 3, 2018
@chrmarti
Copy link
Contributor

chrmarti commented Oct 4, 2018

Reverting for now. On Mac:
image

@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Oct 4, 2018
@Tyriar Tyriar modified the milestones: October 2018, Backlog Oct 8, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Oct 8, 2019

Not sure there's a nice way to do this perfectly without OS-specific CSS rules 😕

@Tyriar Tyriar closed this as completed Oct 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities workbench-welcome Welcome page issues
Projects
None yet
Development

No branches or pull requests

5 participants