Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: Cmd+A does not work in menu help input field #19003

Open
ronyeh opened this issue Jan 22, 2017 · 7 comments
Open

macOS: Cmd+A does not work in menu help input field #19003

ronyeh opened this issue Jan 22, 2017 · 7 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron menus Menu items and widget issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Backlog

Comments

@ronyeh
Copy link

ronyeh commented Jan 22, 2017 •
edited

  • VSCode Version: 1.8.1
  • OS Version: macOS 10.12.2 Sierra

Steps to Reproduce:

  1. Make sure you have an editor open with your most valuable code.
  2. Click on the Help menu item in the menu bar.
  3. Start typing to search the menus. For example, type: "occur"
  4. Realize you wanted to search for something else... so hit CMD+A, DELETE.
  5. ....where did my code go?

Note, this does not happen in Xcode. When you hit CMD+A, the Help menu stays open.

In VSCode, CMD+A closes the Help menu and then selects all of your current editor's contents.
@dbaeumer dbaeumer assigned alexdima and bpasero and unassigned alexdima Jan 23, 2017
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jan 23, 2017
@bpasero bpasero added this to the Backlog milestone Jan 23, 2017
@bpasero
Copy link
Member

bpasero commented Jan 23, 2017

Tough for us to find out that focus is up there, we still think the editor has focus. I think eventually we would need to use roles in our menu items, but that is not fun either because our commands are custom implemented.

@bpasero bpasero mentioned this issue Mar 16, 2017
Closed
@bpasero bpasero added workbench and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Apr 7, 2017
@bpasero bpasero changed the title CMD+A in "Mac Help Menu Search Field" Selects All My Code macOS: Cmd+A does not work in native parts (dialogs, search) Apr 29, 2017
@bpasero bpasero mentioned this issue Apr 29, 2017
Closed
@tholu tholu mentioned this issue Aug 12, 2017
Closed
@bpasero bpasero modified the milestones: September 2017, Backlog Sep 6, 2017
@bpasero bpasero closed this as completed in c2ec62a Sep 6, 2017
@roblourens roblourens added the verification-found Issue verification failed label Sep 27, 2017
@roblourens roblourens reopened this Sep 27, 2017
@roblourens
Copy link
Member

Still reproes following original steps

@bpasero
Copy link
Member

bpasero commented Sep 28, 2017

@roblourens yeah I realize that this bug talks about 2 issues and only one is solved, can you verify this:

  • click save on an untitled file
  • in the dialog try to use Select All, Cut, Copy, Paste via keyboard
    => it should work

Looks like the help menu is not covered by my fix but I also argue that this one is much less of an issue compared to the native dialogs.

@bpasero
Copy link
Member

bpasero commented Sep 28, 2017

@roblourens I suggest to verify this in #22696

@bpasero bpasero modified the milestones: September 2017, Backlog Sep 28, 2017
@bpasero bpasero changed the title macOS: Cmd+A does not work in native parts (dialogs, search) macOS: Cmd+A does not work in menu help input field Sep 28, 2017
@roblourens roblourens added verified Verification succeeded and removed verified Verification succeeded labels Sep 28, 2017
@bpasero bpasero added workbench-electron Electron-VS Code issues and removed verification-found Issue verification failed workbench labels Nov 15, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 15, 2017
@benface
Copy link

benface commented Aug 27, 2018

Any progress on this? It's bitten me a few times already and I've only been using VSC for one day.

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron and removed workbench-electron Electron-VS Code issues labels Sep 25, 2018
@sbatten sbatten added this to the October 2018 milestone Oct 9, 2018
@sbatten sbatten self-assigned this Oct 9, 2018
@sbatten sbatten closed this as completed in bab47f0 Oct 9, 2018
@bpasero bpasero removed their assignment Oct 10, 2018
@sbatten sbatten reopened this Oct 10, 2018
@sbatten
Copy link
Member

sbatten commented Oct 10, 2018

reverted bab47f0 due to #60443

@rsese rsese mentioned this issue Oct 22, 2018
Open
1 task
@sbatten sbatten modified the milestones: October 2018, Backlog Oct 29, 2018
@sbatten sbatten added the menus Menu items and widget issues label Oct 9, 2019
@ronyeh
Copy link
Author

ronyeh commented May 19, 2020 •
edited

I keep running into this bug :-). I think my solution should be to stop using the Help menu to search through VSCode menu items. I did realize that hitting ESC does what I want. So I need to train myself to stop using CMD+A, DELETE to enter a new query, and instead press ESC.

Currently on version 1.45.1 and repros with the same steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron menus Menu items and widget issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@ronyeh @roblourens @bpasero @benface @alexdima @sbatten