Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing line number before the code snippet showed in a search result in the search panel. #190742

Closed
michaelaupetit opened this issue Aug 18, 2023 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@michaelaupetit
Copy link

Missing line number before the code snippet shown in a search result in the search panel.
It would help localize the searched strings in the overall code and identify those sitting in specific functions before clicking on them.
A possible alternative or complementary feature is to highlight in the right panel (showing a larger part of the code as an extended scroll bar) the currently hovered result in the search panel.

@andreamah
Copy link
Contributor

Have you tried enabling search.showLineNumbers? Can you take a screenshot of the bug?

@andreamah andreamah added the info-needed Issue requires more information from poster label Aug 18, 2023
@michaelaupetit
Copy link
Author

Thank you, I did not know where to enter this "search.showLineNumbers" but I finally found the option in Manage>Settings>User>Features>Search>Show Line Numbers.

It works, but it shows the line number on the right side of the result line which makes it unaligned vertically so difficult to track visually.
As it has a fixed length, it would be better to put it on the left side, as all line numbers are left side too in the code editor.
Thank you

@andreamah
Copy link
Contributor

We could make an option for the line numbers to be on the left. I'll make this a feature request candidate to see if others would use this.

@andreamah andreamah added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Aug 21, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Aug 21, 2023
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@michaelaupetit
Copy link
Author

michaelaupetit commented Oct 12, 2023

Screenshot of the issue (red ellipses), solution (green ellipse) would be moving line numbers to the left as in other panels, to ease eye-catch of numbers
VisualCodeLineNumIssue

@elseifthen
Copy link
Contributor

Example of how the search looks when using my patch:
line_numbers

I know I'm biased, but isn't that much better? (o;

@michaelaupetit
Copy link
Author

Sure, it looks great! I hope they will accept your commit! Thank you!

@VSCodeTriageBot
Copy link
Collaborator

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@andreamah andreamah modified the milestones: Backlog, November 2023 Nov 1, 2023
andreamah pushed a commit that referenced this issue Nov 1, 2023
Signed-off-by: Thomas Mitterfellner AVL/GRZ <thomas.mitterfellner@avl.com>
@andreamah
Copy link
Contributor

Fixed by #195452

@andreamah andreamah added the verification-needed Verification of issue is requested label Nov 27, 2023
@aiday-mar aiday-mar added the verified Verification succeeded label Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants