Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test failure (vscode-smoketest-check-extension/time out for search box) #191860

Closed
justschen opened this issue Aug 30, 2023 · 3 comments · Fixed by #192121
Closed

Smoke test failure (vscode-smoketest-check-extension/time out for search box) #191860

justschen opened this issue Aug 30, 2023 · 3 comments · Fixed by #192121
Assignees

Comments

@justschen
Copy link
Contributor

Build: https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=229931
Changes: e2085fa...3217686

1) VSCode Smoke Tests (Web)
       Extensions
         install and enable vscode-smoketest-check extension:
     Error: Timeout: is active element 'div.extensions-viewlet[id="workbench.view.extensions"] .monaco-editor textarea' after 20 seconds.
      at Code.poll (D:\a\_work\1\s\test\automation\src\code.ts:273:11)
      at Code.waitForActiveElement (D:\a\_work\1\s\test\automation\src\code.ts:226:3)
      at Extensions.searchForExtension (D:\a\_work\1\s\test\automation\src\extensions.ts:34:3)
      at Extensions.installExtension (D:\a\_work\1\s\test\automation\src\extensions.ts:60:3)
      at Context.<anonymous> (src\areas\extensions\extensions.test.ts:19:4)
@sandy081
Copy link
Member

playwright-screenshot-1-install_and_enable_vscode-smoketest-check_extension (1)

@bpasero Seems the focus was lost in extensions search box during this. Is there a way to figure out why it was lost?

@bpasero
Copy link
Member

bpasero commented Aug 31, 2023

@sandy081 there is always a smoke-test-runner.log attached to the logs artefacts and it contains the full output from the playwright driver.

image

Here it seems stuck:

[2023-08-30T22:56:13.492Z] getDriverHandle
[2023-08-30T22:56:13.595Z] isActiveElement div.extensions-viewlet[id="workbench.view.extensions"] .monaco-editor textarea
[2023-08-30T22:56:13.595Z] getDriverHandle
[2023-08-30T22:56:13.698Z] Timeout!
[2023-08-30T22:56:13.698Z] page.evaluate: Error: Active element not found. Current active element is 'HTML > BODY.linux.web'. Looking for div.extensions-viewlet[id="workbench.view.extensions"] .monaco-editor textarea
    at y.isActiveElement (http://localhost:9008/insider-3217686db153a4bf9ff11a74beb5288c102c41e4/static/out/vs/workbench/workbench.web.main.js:627:26454)
    at eval (eval at evaluate (:197:30), <anonymous>:1:32)
    at UtilityScript.evaluate (<anonymous>:199:17)
    at UtilityScript.<anonymous> (<anonymous>:1:44)
    at Proxy.isActiveElement (/mnt/vss/_work/1/s/test/automation/src/playwrightDriver.ts:199:20)
    at Code.poll (/mnt/vss/_work/1/s/test/automation/src/code.ts:278:14)
    at Code.waitForActiveElement (/mnt/vss/_work/1/s/test/automation/src/code.ts:226:3)
    at Extensions.searchForExtension (/mnt/vss/_work/1/s/test/automation/src/extensions.ts:34:3)
    at Extensions.installExtension (/mnt/vss/_work/1/s/test/automation/src/extensions.ts:60:3)
    at Context.<anonymous> (/mnt/vss/_work/1/s/test/smoke/src/areas/extensions/extensions.test.ts:19:4)

Focus on body can mean that an element that previously had focus might have been removed from DOM and then the browser defaults to body.

@TylerLeonhardt
Copy link
Member

Skipping this test since it has causes a few build failures.

TylerLeonhardt added a commit that referenced this issue Aug 31, 2023
* Skip flakey smoke test

ref #191860

* skip at describe since there's only 1 test
@sandy081 sandy081 mentioned this issue Sep 4, 2023
sandy081 added a commit that referenced this issue Sep 4, 2023
@sandy081 sandy081 added this to the September 2023 milestone Sep 4, 2023
sandy081 added a commit that referenced this issue Sep 4, 2023
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 4, 2023
@sandy081 sandy081 reopened this Sep 4, 2023
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Sep 4, 2023
@sandy081 sandy081 mentioned this issue Sep 4, 2023
sandy081 added a commit that referenced this issue Sep 4, 2023
sandy081 added a commit that referenced this issue Sep 6, 2023
sandy081 added a commit that referenced this issue Sep 6, 2023
@sandy081 sandy081 closed this as completed Sep 6, 2023
lewis-sanchez added a commit to microsoft/azuredatastudio that referenced this issue Oct 17, 2023
* Recommend release on Stable, pre-release otherwise (#191477)

* fix bug

* add periods

* Add cleaning and logging for extension error data (#191331)

Add cleaning and logging for error data

* Update `EnvironmentVariableScope`

* Update src/vscode-dts/vscode.d.ts

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>

* Misc UX polishes of Quick Chat (#191483)

* rounded bottom
* max height of sash

* fix #191490

* Adds diffEditor.hideUnchangedRegions settings. Fixes #190886, fixes #190887

* Sort slash commands by `yieldTo` (#191112)

* fix #189776

* add accessibility tag

* Apply suggestions from code review

* Light version is always used for `iconPath` (#191127)

* Light version is always used for `iconPath`
Fixes #188830

* Use ThemeService instead

* Uses version2 of diff editor by default.

* Context menu for Quick Search appearing in search view (#191509)

Fixes #191485

* Disable image support by default

This was the cause of the black rectangle when using the DOM renderer
and it appears it can also have that issue with the other renderers.

Fixes #191426

* cli: fix decompression loop stalling (#191512)

Fixes #191501

It turns out this was a difference in inflate/deflate implementations
between the extension/SDK and the CLI. The SDK uses Node's zlib bindings,
while by default Rust's flate2 library uses a rust port of [miniz][1].
The 'logic' in the CLI was good, but miniz does not appear to flush
decompressed data as nicely on SYNC'd boundaries as zlib does, which
caused data to 'stall'. Telling the flate2 crate to use the native
bindings fixed this.

This could also be the cause of the flakiness occasionally seen on idle
tunnel connections!

[1]: https://github.com/richgel999/miniz

* Update workspace trust dialog for ai generated workspaces (#191474)

* Update workspace trust options for ai generated workspaces

* Make this.productService.aiGeneratedWorkspaceTrust optional

* add go to symbol placeholder for accessible view

* change none description

* add requestFocus

* fix #188329

* [css/json/html] update dependencies (#191522)

* Add unit testing for nb sticky scroll (#191524)

* static computeContent for sticky testing

* nb sticky refactor for testing

* move helper fxns to test suite

* Fix trustOption string content (#191525)

* React to window resize and remove hardcoded maxHeight in Quick Chat (#191531)

more Quick Chat polish

* Have sash take over layouting of Quick Chat until reset (double click) (#191533)

The new behavior is that when you use the sash to change the height, then you are locked into that. It's not until you double click, or clear the chat that it returns to the original behavior of being open for just the last question.

* Remove toolbar button to @-mention a response (#191534)

* behavior fixes, align more closely with editor

* behavior fixes for nb sticky scroll + css fix

* server-web: implement secret storage provider (#191538)

Works quite similarly to vscode.dev. The client has a key stored in
secret storage. The server has a key stored server-side, and issues
an http-only cookie to the client. The client can ask the server to
combine its key and the http-only cookie key to a key component, which
it combines with its local key to encrypt and decrypt data.

This logic kicks in if the web server bits see a `vscode-secret-key-path`
cookie set when it loads.

* A few tests for Related Information (#191547)

* Turn on Command Center by default (#191550)

* Turn on Command Center by default

Fixes microsoft/vscode#191549

* remove tag

* Add GNU style link 'r-c.ce', 'r.c-re.ce'

See https://www.gnu.org/prep/standards/html_node/Errors.html

sourcefile:line1.column1-line2.column2: message
sourcefile:line1.column1-column2: message
sourcefile:line1-line2: message

Fixes #190350

* fix #191374

* chore: update distro (#191633)

* quick search - file highlight decoration isn't showing up on search (#191544)

Fixes #191539

* Dim settings and keybindings editors

Fixes #191612
Fixes #191611

* add onDidRunText

* Dim breadcrumbs

Fixes #191608

* revert some changes

* Prefer .editor-group-container over .editor-instance

* Dim editor placeholder

Fixes #191614

* Dim welcome editor

Fixes #191613

* Dim unfocused setting feedback

Fixes #191618

* tunnels: fix forwarding attempts wrong path to tunnel binary on linux (#191657)

Fixes #191621

* Amend

* Notification and notification buttons lack border radius (fix #191532) (#191557)

* add screencastMode.keyboardOptions.showKeybindings (#191686)

fixes #179541

* Fix dim unfocused settings link

Fixes #191643

* Use correct check for just focusing (#191696)

fixes https://github.com/microsoft/vscode-internalbacklog/issues/4580

* Action widget fuzzyMatch fix (#191687)

fixes fuzzy matching confusion - makes sure only finds exact matching

* serve-web: delete socket file on server shutdown (#191692)

Fixes #191691

* fix #191591

* fix #191672

* fix #191684

* fix #191722

* Skip Nb Sticky Scroll testing on web platform. (#191716)

* test change

* skip notebook sticky scroll testing on web

* Clicking into notebook markdown search result clears result (#191731)

Fixes #191666

* Don't allow taking action on codeblocks in filtered responses (#191732)

Fix microsoft/vscode-copilot#1148

* add custom hover for quick open (#191416)

* add custom hover for quick open

* 💄

* 💄

* adjust delayer create logic

* Only decorate complete @ variables (#191733)

* chore: update electron@25.7.0 (#191282)

* chore: update electron@25.7.0

* chore: update internal build id

* chore: bump distro

* fix #191734 (#191756)

* fix #191022 (#191760)

* Fixes #191664

* Configure Tunnel Name leads to empty settings page for WSL (#191761)

* Fixes #191637

* Fixes #191600

* listWidget: remove redundant logic (#191054)

* Fixes #191603

* changing the setting text

* voice - fix issues around stopping transcription (#191774)

* Fix another `var()` fallback case (#191721)

One more case of #190968

* allow workspace edit to "create" untitled files (#191779)

https://github.com/microsoft/vscode-copilot/issues/1261

* voice - fix bad controller when using toolbar actions (#191780)

* Git - update Explorer welcome view context key (#191788)

* Fixes #191323

* Revert "fix #190228 (#191207)" (#191789)

This reverts commit cafcb59.

* Workaround slow update webgl issue on Windows

Fixes #190195

* cli: verify vscode server integrity before committing to cache (#191792)

Fixes #191469

* voice - replace codicon when hovering over stop button (#191777)

* cli: recycle all tunnels the cli creates for all scenarios (#191800)

Fixes #191749

* voice - make stop icon more explicit

* set default focusAfterRun to none

* voice - add a new action to stop and accept voice input (#191802)

* Disable renderer unit test on Windows

* changed command title and name

* Update distro

Fixes #191605

* make sure codeEditor is set when bulk editing via diff editor (#191810)

re microsoft/vscode#188385

* Remove windows check

* Disable test

* forwarding: fix formatting issues in the log (#191814)

Fixes #191759

* Fix import

* fix #188329

* cli: polish serve-web help (#191817)

Fixes #191601

* Fix error in zsh si script

Fixes #188875

* Update src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* on blur, hide

* debug: bump js-debug to 1.82 (#191827)

* allow more output mime types to be copied

* Fix file tree not being transferred to panel chat (#191826)

* Fix rendering when chat is hidden (#191830)

Fixes microsoft/vscode#191704

* adjust endgame query (#191806)

* Diff Editor: Disables optimistic diff updates. Fixes #190748, Fixes #190232

* Uncomment unused symbols.

* Fixes CI

* Fix screen reader for comment editor (#191828)

* Try forwarding the accessibility support setting to the comment editor

* Add isAccessible to comment view
Fixes #146994

* Update codicons (#191835)

* Fixes #191617

* fix: prevent history show prev/next in composing event (#184014)

* look for re-used output id containing the image

* normalize option name

* cleanup

* get `x` off the edge (#191849)

Fixes microsoft/vscode#191701

* Partially revert a change that broke dimming in active group

Reopens #191608

* Show focus state on editor tabs in hc themes (#191850)

* Fix progressive rendering of updated markdown content (#191851)

Fix progressive rendering updated markdown content

* view descriptor created with containerTitle that is not a string (#191842)

* reinstate `github-auth` parameter that was accidentally removed (#191862)

Fixes microsoft/vscode#191861

* After 30s re-layout the quick chat (#191853)

fixes microsoft/vscode#191627

* wrap handler for resize observer in requestAnimationFrame() (#183325)

* wrap handler for resize observer in requestAnimationFrame()

(fixes #183324)

* React immediately on first notification during an animation frame and only delay the second notification during the same animation frame

---------

Co-authored-by: Karel Frederix <kfrederix@selligent.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>

* voice - start to better understand different chat input contexts (#191884)

* voice - start to have context and actions per chat kind

* voice - add context to `stop`

* voice - add todo for focus issue when starting

* window.title setting feedback (fix #191579) (#191885)

* some Some grid operations cause the `activeElement` to get lost (fix #189256) (#191886)

* Linux: Notifications Accessible View only opens when focusing with mouse (fix #191705) (#191888)

* Initialize all services as soon as the first service is needed (#191890)

Fixes microsoft/monaco-editor#4120: initialize all services as soon as the first service is needed

* Fixes #191892

* fix #186904

* check if mac

* Don't throw if view doesn't exist when visibility false (#191781)

* fix issue

* different udf check

* Update src/vs/workbench/contrib/terminalContrib/accessibility/browser/textAreaSyncAddon.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Disable Local Server flow for REH (#191930)

Because spinning up ports on the remote won't always work. Instead, we have the trusty device code flow.

Fixes microsoft/vscode#191866
Fixes microsoft/vscode#191867

* Do not show parent checkbox contents for ai generated workspaces (#191933)

* Skip flakey smoke test (#191936)

* Skip flakey smoke test

ref microsoft/vscode#191860

* skip at describe since there's only 1 test

* Add check to see if resource has file extension before setting FILE | FOLDER (#191923)

* Set resource as FILE only if children are undefined

* Add check to see if resource has extension before setting FileKind

* Only update layout when chat is visible (#191943)

Fixes microsoft/vscode#191942

* Don't show chat widget context menu for filetree (#191940)

* Open walkthrough if a gettingStarted page is found (#191947)

* chore: bump electron@25.8.0 (#191905)

* chore: bump electron@25.8.0

* chore: update internal build id

* chore: bump distro

* editors - do not focus empty editor group when created (#191963)

* Enable the family autodetection algorithm (#191970)

Fixes #191945: Enable the family autodetection algorithm to support a case where localhost resolves first to the ipv6 address and only second to the ipv4 address, and the desired server listens only on ipv4

* update distro

* Restore default paste fallback (#192220)

Fixes #192196

* Empty commit to release/1.82 (#192341)

* Add setting to disable chat history variables

* fix npm view exploits

* Version bump

* Version bump

* prioritize html links since they can wrap other link types

* Add missing vscode known variables

* Fix merge conflict with yarn locks

* Fix merge conflicts with build js files

* Fix extensions dir compilation errors

* Fix compilation errors

* More compilation error fixes

* Defines missing methods for treeViews

* More compilation time error fixes

* Fix remaining compile time issues

* Declares argvConfig to launch

* Fixes untrusted HTML issue for ADS launch

* Fix failing core unit tests

* Fix windows build pipeline

* Fix electron version

* Add prepare steps for deb and rpm packages

* Update distro hash

* Fix sql product build linux file

* Fix indentation with linux build file

* Update distro hash

* Update distro hash again

* Update node version to v18.x

* Update node to 18.15.13

* Update node to 18.15.0

* Turn off hygiene temporarily

* Fix build directory compilation issues

* Turns off failing tests

* Disable failing suite

* Update sqlite release version to 1.16.0

* Update distro hash

* Adds back XML language features extension

* Bump vscode version to 1.82.0

* Update vscode link with ADS link

* Fix issue with ts-node module resolution

* Add missing sql carbon edit tag

* Reenable linting in sql product compile script

* Update distro hash

* Add missing sql carbon edit tags

* Correct node js version

* Update nodejs version in ci.yml

* Revert "Update nodejs version in ci.yml"

This reverts commit 4694ace.

* Revert "Correct node js version"

This reverts commit fb48649.

* Update nodejs version for github workflows

* Reorder how deps are installed

* Revert "Reorder how deps are installed"

This reverts commit e0fbceb.

* Revert "Update nodejs version for github workflows"

This reverts commit eb5d819.

* Use nodejs v16 for github checks

* Bump nodejs to v18

* Update version to 18.15

* Fix basic

* Fix issue with yarn with hygiene check

* Fix yarn step in hygiene

---------

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Logan Ramos <lramos15@gmail.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com>
Co-authored-by: Hans <weartistt@gmail.com>
Co-authored-by: troy351 <914053923@qq.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
Co-authored-by: Aaron Munger <aamunger@microsoft.com>
Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: songlinn <17741492+songlinn@users.noreply.github.com>
Co-authored-by: Karel Frederix <karelfrederix@gmail.com>
Co-authored-by: Karel Frederix <kfrederix@selligent.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Christof Marti <chrmarti@microsoft.com>
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>
stuti149 added a commit to microsoft/azuredatastudio that referenced this issue Oct 18, 2023
* Fix to Disable Apply button for Query Store tab when no changes are made (#24573)

* fix to Disable Apply button for Query Store tab when no changes are made

* typo

* wrong name is displying in query store section

* Handle some server properties not being supported for certain SQL versions (#24587)

* Co-authored-by: Benjin Dubishar <benjind@microsoft.com>

* update commit hash for AGC merge (#24622)

* Transfer URI Correctly (#24614)

* transfer uri regardless of queryrunner presence

* throw error if new URI already exists

* bump sts version

* [Loc] update to xlfs 10-9-2023 (#24626)

* Use python 3.11 (#24646)

* changelog for 1.46.1 (#24575)

* [Loc] removed noQueryRunnerForUri (#24648)

* Update distro commit to 37199be (#24647)

* add schema migration (#24594)

* add schema migration

* fix table selection issue

* fix table validation

* data only wont show schema info grids

* address comments

* update schema migration helper banner

* fix undefined

* refactor

* endedOn is - when not started

* fix toString

* refactor

* auto referesh dashboardtab and migrationtab

* add migration type in dashboard

* fix saving issue in page 0 and page 1

* fix compile issue

* fix save and close in page 3

* refactor

* fix save

* fix save

* fix save

* dont load location twice

* fix target type undefined issue

* set MI as default

* fix cannot load in step 3

* integrate assessment with schema

---------

Co-authored-by: Siyang Yao <siyao@microsoft.com>

* Revert "add schema migration (#24594)" (#24652)

This reverts commit f70ff23.

* Fix clear pooled connection title (#24650)

* Add tooltips with advanced options on hover for editor tabs (#24486)

* Added WIP table designer input change

* added test details to tableDesigner

* added connection name to details

* wip restoration of nonDefaultOptions

* added Verbosity todo for getTitle

* added updated info

* added fix for mainController

* fixed assignment

* added update to description

* restore title parts to old names

* added clarifying message

* added title to dashboard and profilerinput

* added advanced titles for edit data and query editor input

* added changes based on feedback

* added additional description

* Added some changes to tableDesigner input

* fixed comments

* removed erroneous import

* added updated titles and tooltips

* added small corrections

* added profiler XEL title feature

* added session name to profiler input tooltip

* added small tooltip rework

* remove unavailable session name

* added update to config.json

* fix bugs (#24654)

Co-authored-by: Siyang Yao <siyao@microsoft.com>

* [Loc] xlf update 10-11-2023 (#24657)

* Bump STS version to 4.10.0.17 (#24658)

* Pass Http proxy URL and strict SSL flag to backend STS (#24550)

* Improves "save as Excel" functionality (#24653)

* update sql projects azdata dependency (#24662)

* Update distro commit to 8c77b17 (#24663)

* update distro commit hash

* remove build step

* Specify object type in context menu when creating a new object (#24641)

* [Loc] update to xlfs for 10-12-2023 (#24668)

* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20231013154213358. (#24673)

* vbump sql projects after insiders release (#24675)

* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20231014154038549. (#24680)

* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20231015153850591. (#24682)

Co-authored-by: Alex Ma <alma1@microsoft.com>

* Fix so screenreaders will announce section headers in sql projects dialogs (#24678)

* update create project from db dialog to use gropus for screen reader

* switch update project from db dialog to also use groups

* Merge VS Code version 1.82 into Azure Data Studio (#24684)

* Recommend release on Stable, pre-release otherwise (#191477)

* fix bug

* add periods

* Add cleaning and logging for extension error data (#191331)

Add cleaning and logging for error data

* Update `EnvironmentVariableScope`

* Update src/vscode-dts/vscode.d.ts

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>

* Misc UX polishes of Quick Chat (#191483)

* rounded bottom
* max height of sash

* fix #191490

* Adds diffEditor.hideUnchangedRegions settings. Fixes #190886, fixes #190887

* Sort slash commands by `yieldTo` (#191112)

* fix #189776

* add accessibility tag

* Apply suggestions from code review

* Light version is always used for `iconPath` (#191127)

* Light version is always used for `iconPath`
Fixes #188830

* Use ThemeService instead

* Uses version2 of diff editor by default.

* Context menu for Quick Search appearing in search view (#191509)

Fixes #191485

* Disable image support by default

This was the cause of the black rectangle when using the DOM renderer
and it appears it can also have that issue with the other renderers.

Fixes #191426

* cli: fix decompression loop stalling (#191512)

Fixes #191501

It turns out this was a difference in inflate/deflate implementations
between the extension/SDK and the CLI. The SDK uses Node's zlib bindings,
while by default Rust's flate2 library uses a rust port of [miniz][1].
The 'logic' in the CLI was good, but miniz does not appear to flush
decompressed data as nicely on SYNC'd boundaries as zlib does, which
caused data to 'stall'. Telling the flate2 crate to use the native
bindings fixed this.

This could also be the cause of the flakiness occasionally seen on idle
tunnel connections!

[1]: https://github.com/richgel999/miniz

* Update workspace trust dialog for ai generated workspaces (#191474)

* Update workspace trust options for ai generated workspaces

* Make this.productService.aiGeneratedWorkspaceTrust optional

* add go to symbol placeholder for accessible view

* change none description

* add requestFocus

* fix #188329

* [css/json/html] update dependencies (#191522)

* Add unit testing for nb sticky scroll (#191524)

* static computeContent for sticky testing

* nb sticky refactor for testing

* move helper fxns to test suite

* Fix trustOption string content (#191525)

* React to window resize and remove hardcoded maxHeight in Quick Chat (#191531)

more Quick Chat polish

* Have sash take over layouting of Quick Chat until reset (double click) (#191533)

The new behavior is that when you use the sash to change the height, then you are locked into that. It's not until you double click, or clear the chat that it returns to the original behavior of being open for just the last question.

* Remove toolbar button to @-mention a response (#191534)

* behavior fixes, align more closely with editor

* behavior fixes for nb sticky scroll + css fix

* server-web: implement secret storage provider (#191538)

Works quite similarly to vscode.dev. The client has a key stored in
secret storage. The server has a key stored server-side, and issues
an http-only cookie to the client. The client can ask the server to
combine its key and the http-only cookie key to a key component, which
it combines with its local key to encrypt and decrypt data.

This logic kicks in if the web server bits see a `vscode-secret-key-path`
cookie set when it loads.

* A few tests for Related Information (#191547)

* Turn on Command Center by default (#191550)

* Turn on Command Center by default

Fixes microsoft/vscode#191549

* remove tag

* Add GNU style link 'r-c.ce', 'r.c-re.ce'

See https://www.gnu.org/prep/standards/html_node/Errors.html

sourcefile:line1.column1-line2.column2: message
sourcefile:line1.column1-column2: message
sourcefile:line1-line2: message

Fixes #190350

* fix #191374

* chore: update distro (#191633)

* quick search - file highlight decoration isn't showing up on search (#191544)

Fixes #191539

* Dim settings and keybindings editors

Fixes #191612
Fixes #191611

* add onDidRunText

* Dim breadcrumbs

Fixes #191608

* revert some changes

* Prefer .editor-group-container over .editor-instance

* Dim editor placeholder

Fixes #191614

* Dim welcome editor

Fixes #191613

* Dim unfocused setting feedback

Fixes #191618

* tunnels: fix forwarding attempts wrong path to tunnel binary on linux (#191657)

Fixes #191621

* Amend

* Notification and notification buttons lack border radius (fix #191532) (#191557)

* add screencastMode.keyboardOptions.showKeybindings (#191686)

fixes #179541

* Fix dim unfocused settings link

Fixes #191643

* Use correct check for just focusing (#191696)

fixes https://github.com/microsoft/vscode-internalbacklog/issues/4580

* Action widget fuzzyMatch fix (#191687)

fixes fuzzy matching confusion - makes sure only finds exact matching

* serve-web: delete socket file on server shutdown (#191692)

Fixes #191691

* fix #191591

* fix #191672

* fix #191684

* fix #191722

* Skip Nb Sticky Scroll testing on web platform. (#191716)

* test change

* skip notebook sticky scroll testing on web

* Clicking into notebook markdown search result clears result (#191731)

Fixes #191666

* Don't allow taking action on codeblocks in filtered responses (#191732)

Fix microsoft/vscode-copilot#1148

* add custom hover for quick open (#191416)

* add custom hover for quick open

* 💄

* 💄

* adjust delayer create logic

* Only decorate complete @ variables (#191733)

* chore: update electron@25.7.0 (#191282)

* chore: update electron@25.7.0

* chore: update internal build id

* chore: bump distro

* fix #191734 (#191756)

* fix #191022 (#191760)

* Fixes #191664

* Configure Tunnel Name leads to empty settings page for WSL (#191761)

* Fixes #191637

* Fixes #191600

* listWidget: remove redundant logic (#191054)

* Fixes #191603

* changing the setting text

* voice - fix issues around stopping transcription (#191774)

* Fix another `var()` fallback case (#191721)

One more case of #190968

* allow workspace edit to "create" untitled files (#191779)

https://github.com/microsoft/vscode-copilot/issues/1261

* voice - fix bad controller when using toolbar actions (#191780)

* Git - update Explorer welcome view context key (#191788)

* Fixes #191323

* Revert "fix #190228 (#191207)" (#191789)

This reverts commit cafcb59.

* Workaround slow update webgl issue on Windows

Fixes #190195

* cli: verify vscode server integrity before committing to cache (#191792)

Fixes #191469

* voice - replace codicon when hovering over stop button (#191777)

* cli: recycle all tunnels the cli creates for all scenarios (#191800)

Fixes #191749

* voice - make stop icon more explicit

* set default focusAfterRun to none

* voice - add a new action to stop and accept voice input (#191802)

* Disable renderer unit test on Windows

* changed command title and name

* Update distro

Fixes #191605

* make sure codeEditor is set when bulk editing via diff editor (#191810)

re microsoft/vscode#188385

* Remove windows check

* Disable test

* forwarding: fix formatting issues in the log (#191814)

Fixes #191759

* Fix import

* fix #188329

* cli: polish serve-web help (#191817)

Fixes #191601

* Fix error in zsh si script

Fixes #188875

* Update src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* on blur, hide

* debug: bump js-debug to 1.82 (#191827)

* allow more output mime types to be copied

* Fix file tree not being transferred to panel chat (#191826)

* Fix rendering when chat is hidden (#191830)

Fixes microsoft/vscode#191704

* adjust endgame query (#191806)

* Diff Editor: Disables optimistic diff updates. Fixes #190748, Fixes #190232

* Uncomment unused symbols.

* Fixes CI

* Fix screen reader for comment editor (#191828)

* Try forwarding the accessibility support setting to the comment editor

* Add isAccessible to comment view
Fixes #146994

* Update codicons (#191835)

* Fixes #191617

* fix: prevent history show prev/next in composing event (#184014)

* look for re-used output id containing the image

* normalize option name

* cleanup

* get `x` off the edge (#191849)

Fixes microsoft/vscode#191701

* Partially revert a change that broke dimming in active group

Reopens #191608

* Show focus state on editor tabs in hc themes (#191850)

* Fix progressive rendering of updated markdown content (#191851)

Fix progressive rendering updated markdown content

* view descriptor created with containerTitle that is not a string (#191842)

* reinstate `github-auth` parameter that was accidentally removed (#191862)

Fixes microsoft/vscode#191861

* After 30s re-layout the quick chat (#191853)

fixes microsoft/vscode#191627

* wrap handler for resize observer in requestAnimationFrame() (#183325)

* wrap handler for resize observer in requestAnimationFrame()

(fixes #183324)

* React immediately on first notification during an animation frame and only delay the second notification during the same animation frame

---------

Co-authored-by: Karel Frederix <kfrederix@selligent.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>

* voice - start to better understand different chat input contexts (#191884)

* voice - start to have context and actions per chat kind

* voice - add context to `stop`

* voice - add todo for focus issue when starting

* window.title setting feedback (fix #191579) (#191885)

* some Some grid operations cause the `activeElement` to get lost (fix #189256) (#191886)

* Linux: Notifications Accessible View only opens when focusing with mouse (fix #191705) (#191888)

* Initialize all services as soon as the first service is needed (#191890)

Fixes microsoft/monaco-editor#4120: initialize all services as soon as the first service is needed

* Fixes #191892

* fix #186904

* check if mac

* Don't throw if view doesn't exist when visibility false (#191781)

* fix issue

* different udf check

* Update src/vs/workbench/contrib/terminalContrib/accessibility/browser/textAreaSyncAddon.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Disable Local Server flow for REH (#191930)

Because spinning up ports on the remote won't always work. Instead, we have the trusty device code flow.

Fixes microsoft/vscode#191866
Fixes microsoft/vscode#191867

* Do not show parent checkbox contents for ai generated workspaces (#191933)

* Skip flakey smoke test (#191936)

* Skip flakey smoke test

ref microsoft/vscode#191860

* skip at describe since there's only 1 test

* Add check to see if resource has file extension before setting FILE | FOLDER (#191923)

* Set resource as FILE only if children are undefined

* Add check to see if resource has extension before setting FileKind

* Only update layout when chat is visible (#191943)

Fixes microsoft/vscode#191942

* Don't show chat widget context menu for filetree (#191940)

* Open walkthrough if a gettingStarted page is found (#191947)

* chore: bump electron@25.8.0 (#191905)

* chore: bump electron@25.8.0

* chore: update internal build id

* chore: bump distro

* editors - do not focus empty editor group when created (#191963)

* Enable the family autodetection algorithm (#191970)

Fixes #191945: Enable the family autodetection algorithm to support a case where localhost resolves first to the ipv6 address and only second to the ipv4 address, and the desired server listens only on ipv4

* update distro

* Restore default paste fallback (#192220)

Fixes #192196

* Empty commit to release/1.82 (#192341)

* Add setting to disable chat history variables

* fix npm view exploits

* Version bump

* Version bump

* prioritize html links since they can wrap other link types

* Add missing vscode known variables

* Fix merge conflict with yarn locks

* Fix merge conflicts with build js files

* Fix extensions dir compilation errors

* Fix compilation errors

* More compilation error fixes

* Defines missing methods for treeViews

* More compilation time error fixes

* Fix remaining compile time issues

* Declares argvConfig to launch

* Fixes untrusted HTML issue for ADS launch

* Fix failing core unit tests

* Fix windows build pipeline

* Fix electron version

* Add prepare steps for deb and rpm packages

* Update distro hash

* Fix sql product build linux file

* Fix indentation with linux build file

* Update distro hash

* Update distro hash again

* Update node version to v18.x

* Update node to 18.15.13

* Update node to 18.15.0

* Turn off hygiene temporarily

* Fix build directory compilation issues

* Turns off failing tests

* Disable failing suite

* Update sqlite release version to 1.16.0

* Update distro hash

* Adds back XML language features extension

* Bump vscode version to 1.82.0

* Update vscode link with ADS link

* Fix issue with ts-node module resolution

* Add missing sql carbon edit tag

* Reenable linting in sql product compile script

* Update distro hash

* Add missing sql carbon edit tags

* Correct node js version

* Update nodejs version in ci.yml

* Revert "Update nodejs version in ci.yml"

This reverts commit 4694ace.

* Revert "Correct node js version"

This reverts commit fb48649.

* Update nodejs version for github workflows

* Reorder how deps are installed

* Revert "Reorder how deps are installed"

This reverts commit e0fbceb.

* Revert "Update nodejs version for github workflows"

This reverts commit eb5d819.

* Use nodejs v16 for github checks

* Bump nodejs to v18

* Update version to 18.15

* Fix basic

* Fix issue with yarn with hygiene check

* Fix yarn step in hygiene

---------

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Logan Ramos <lramos15@gmail.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com>
Co-authored-by: Hans <weartistt@gmail.com>
Co-authored-by: troy351 <914053923@qq.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
Co-authored-by: Aaron Munger <aamunger@microsoft.com>
Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: songlinn <17741492+songlinn@users.noreply.github.com>
Co-authored-by: Karel Frederix <karelfrederix@gmail.com>
Co-authored-by: Karel Frederix <kfrederix@selligent.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Christof Marti <chrmarti@microsoft.com>
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>

* removing duplicate group by schema commands commands (#24660)

* Fix command name for Group by Schema (#24710)

---------

Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: erpett <97994807+erpett@users.noreply.github.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Siyang Yao <ysy68251435@gmail.com>
Co-authored-by: Siyang Yao <siyao@microsoft.com>
Co-authored-by: Chris Kaczor <chris@kaczorzoo.net>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: CSIGS@microsoft.com <csigs@users.noreply.github.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Logan Ramos <lramos15@gmail.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com>
Co-authored-by: Hans <weartistt@gmail.com>
Co-authored-by: troy351 <914053923@qq.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
Co-authored-by: Aaron Munger <aamunger@microsoft.com>
Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: songlinn <17741492+songlinn@users.noreply.github.com>
Co-authored-by: Karel Frederix <karelfrederix@gmail.com>
Co-authored-by: Karel Frederix <kfrederix@selligent.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Christof Marti <chrmarti@microsoft.com>
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants