Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test warnings: Throttler is disposed #192425

Closed
Tyriar opened this issue Sep 7, 2023 · 3 comments
Closed

Unit test warnings: Throttler is disposed #192425

Tyriar opened this issue Sep 7, 2023 · 3 comments
Assignees
@bpasero
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders unit-test-failure
Milestone
September 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 7, 2023

When running unit tests:

  Lifecycleservice
    + onBeforeShutdown - final veto called after other vetos
    + onBeforeShutdown - final veto not called when veto happened before
    + onBeforeShutdown - veto with error is treated as veto
[15408:0907/082437.869:INFO:CONSOLE(0)] "Uncaught (in promise) Error: Fail", source: file:///C:/Github/microsoft/vscode/test/unit/electron/renderer.html (0)
    + onBeforeShutdown - final veto with error is treated as veto
[15408:0907/082437.891:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.891:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.891:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.892:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.892:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.892:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.892:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.892:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.892:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.892:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.892:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.893:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.894:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.895:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.896:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.897:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.898:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.899:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.899:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.899:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.899:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.899:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.899:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.899:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.900:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.901:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.901:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.901:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.901:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.901:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.901:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.902:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
[15408:0907/082437.903:INFO:CONSOLE(150)] "Uncaught (in promise) Error: Throttler is disposed", source: file:///C:/Github/microsoft/vscode/out/vs/base/common/async.js (150)
    + onWillShutdown - join
    + onWillShutdown - join with error is handled
[15408:0907/082437.924:INFO:CONSOLE(109)] "Uncaught (in promise) Error: Fail", source: file:///C:/Github/microsoft/vscode/out/vs/workbench/services/lifecycle/test/electron-sandbox/lifecycleService.test.js (109)
@Tyriar
Copy link
Member Author

Tyriar commented Sep 7, 2023

Similar problem in UntitledFileWorkingCopy

Tyriar added a commit that referenced this issue Sep 7, 2023
@Tyriar
Fix Throttler dispose warning in unit tests
34eeab3 
This was happening because dispose was being overridden so the isDisposed check
before a store is disposed again wasn't happening just for the throttler.

Fixes #192427
Fixes #192434
Part of #192425
@Tyriar Tyriar mentioned this issue Sep 7, 2023
Merged
@bpasero bpasero changed the title Concerning logs in LifecycleService unit test output Unit test error: Throttler is disposed Sep 7, 2023
@bpasero bpasero added debt Code quality issues unit-test-failure labels Sep 7, 2023
@bpasero bpasero modified the milestones: On Deck, September 2023 Sep 7, 2023
@bpasero
Copy link
Member

bpasero commented Sep 7, 2023 •
edited

This is not coming from those tests, the ugly part is these errors just report async.

I found the following tests to be the underlying cause:

  • src/vs/workbench/services/label/test/browser/label.test.ts @bpasero
  • src/vs/workbench/contrib/terminal/test/common/environmentVariableService.test.ts @Tyriar
  • src/vs/workbench/services/views/test/browser/viewContainerModel.test.ts @sandy081

The best is to run scripts/test.sh --dev and add a breakpoint here:

vscode/src/vs/base/common/async.ts

Line 185 in c275a04

throw new Error('Throttler is disposed');

@bpasero bpasero changed the title Unit test error: Throttler is disposed Unit test warnings: Throttler is disposed Sep 7, 2023
@bpasero
Copy link
Member

bpasero commented Sep 8, 2023

I think I may have found a central fix...

bpasero added a commit that referenced this issue Sep 8, 2023
@bpasero
Unit test warnings: Throttler is disposed (fix #192425)
61007c9
@bpasero bpasero closed this as completed in 6777698 Sep 8, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders unit-test-failure
Projects
None yet
Milestone
September 2023
Development

No branches or pull requests
4 participants
@bpasero @Tyriar @sandy081 @VSCodeTriageBot