-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll lock icon does not fit with the rest of the icon set #19362
Comments
This is the final icon which we got from the icon people. I agree it looks alien, but I think we can ship with it. @chrisdias do we have a contact from the icon folk that we can ping for issues like this? |
@kieferrm do we have a contact from the icon folk who we can ping for issues like this? |
Sorry, the scroll lock is what I meant. |
@chrisdias yeah the scroll lock. Do we have someone to bother for icons or should I invest in icon designing skills :) |
Looks good, I also like that there are two versions. Currently we keep the button with a blue outline when clicked which imho looks too much like the focus outline. |
Look at @chrisdias closing bugs like a boss left and right - thanks a lot! The only issue I encountered while browsing through https://vsicons.azurewebsites.net/ is that I could not find the inverse version of the icons - in our case for the use in the dark theme. How can I get those? I figured I could manually edit the svg but hopefully there is a better way :) fyi @ArtemGovorov for possible feedback on the icon |
We have to get the inverse icon created. I'll do that for the empty lock icons and give you the open and the close so that you can toggle it instead of using the blue outline. |
@isidorn that site only shows standard light theme icons created for Visual Studio. VS Code icons are similar in concept but produced in a slightly different way. If there is any icon need for VS Code, a Microsoft member will reach out to the UX and the UX will create proper light theme and dark theme svg files. |
@isidorn here are the lock/unlock icons: |
Thanks @chrisdias for the icons! What is the process of making the inverse - just manual work in some tool? Asking because I would like to be able to do that myself :) |
@isidorn I have some gulp tasks to make VS Code icon from a regular VS icon. Inversion is just find & replace. You can see the hex color mapping here |
@chryw awesome - thanks a lot! |
Is this temporary until we have a real icon? Imho it does not fit to any other icon we have there, neither in size nor in shape.
The text was updated successfully, but these errors were encountered: