Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response in progress audio cue loops forever sometimes #194424

Closed
meganrogge opened this issue Sep 28, 2023 · 5 comments · Fixed by #194676 or #196626
Closed

response in progress audio cue loops forever sometimes #194424

meganrogge opened this issue Sep 28, 2023 · 5 comments · Fixed by #194676 or #196626
Assignees
@meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
October 2023

Comments

@meganrogge
Copy link
Contributor

  1. with screen reader mode on, in the inline chat, type generate some tests for this, with a selection
  2. 🐛 in progress response audio cue plays forever until I reload the window even though the response has come back
@meganrogge meganrogge self-assigned this Sep 28, 2023
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Sep 28, 2023
@meganrogge meganrogge added this to the October 2023 milestone Sep 28, 2023
meganrogge added a commit that referenced this issue Oct 2, 2023
@meganrogge
fix #194424
e09fd7a
@meganrogge meganrogge mentioned this issue Oct 2, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 4, 2023
@meganrogge meganrogge reopened this Oct 24, 2023
@meganrogge
Copy link
Contributor Author

There's still a case that's not covered.

@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Oct 24, 2023
meganrogge added a commit that referenced this issue Oct 25, 2023
@meganrogge
fix #194424
21e6c2d
@meganrogge
Copy link
Contributor Author

Example for what caused this:

  1. Enable screen reader mode
  2. Open vscode, run "@workspace which parts of the code have the most to do comments"
  3. It will take a long time to reply. Ensure the chat in progress audio cue stops playing.

@meganrogge meganrogge mentioned this issue Oct 25, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 25, 2023
@jrieken jrieken reopened this Oct 26, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Oct 26, 2023
@jrieken
Copy link
Member

jrieken commented Oct 26, 2023

@meganrogge I have reverted your changes because release does not mean accept session. Release happens on accept, error, cancel etc. Understand this as disposing an object

Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@meganrogge @Alex0007
fix microsoft#194424
a6a4099
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@meganrogge @Alex0007
fix microsoft#194424
556ceee
@meganrogge
Copy link
Contributor Author

Yep @jrieken in that case, we want to accept the response, which cancels the audio cue but doesn't announce the response was completed. Pls revert the revert so this is fixed

This was referenced Oct 26, 2023
Closed
Merged
jrieken added a commit that referenced this issue Oct 26, 2023
@jrieken
local usage of _chatAccessibilityService, don't spread it around the …
a67ea3d 
…state machine

#194424
jrieken added a commit that referenced this issue Oct 26, 2023
@jrieken
local usage of _chatAccessibilityService, don't spread it around the …
5a8659a 
…state machine (#196737)

#194424
@meganrogge
Copy link
Contributor Author

/closedWith 5a8659a

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 26, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 26, 2023
@amunger amunger added the verified Verification succeeded label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
October 2023
4 participants
@jrieken @amunger @meganrogge @VSCodeTriageBot