Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Support a custom setting for users to jump to terminal input from accessible buffer by typing #195582

Closed
jooyoungseo opened this issue Oct 13, 2023 · 6 comments · Fixed by #195737
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode
Milestone

Comments

@jooyoungseo
Copy link

jooyoungseo commented Oct 13, 2023

Type: Feature Request

CC @meganrogge

I am a heavy terminal user and very frequently go back and forth accessible terminal view and terminal input.

In order to type something after verifying the terminal output in the buffer, I have to either press ctrl+DownArrow or ESC key first.

It would be even better if I could start typing in terminal buffer and it directly goes to the terminal input. Plese consider adding this c customization for some advanced users for their improved productivity.

VS Code version: Code - Insiders 1.84.0-insider (4678919, 2023-10-13T05:34:13.175Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Remote OS version: Linux x64 4.18.0-477.27.1.el8_8.x86_64

@meganrogge meganrogge self-assigned this Oct 13, 2023
@meganrogge meganrogge added feature-request Request for new features or functionality terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode labels Oct 13, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Oct 13, 2023
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@jooyoungseo
Copy link
Author

jooyoungseo commented Oct 13, 2023 via email

@meganrogge
Copy link
Contributor

Yes, there is a way. I've linked a PR that does mostly what you described. There are a few complications to sort out. If we do this, I'm not sure a setting would be needed, since most users would want this, I think?

@jooyoungseo
Copy link
Author

jooyoungseo commented Oct 13, 2023 via email

@meganrogge
Copy link
Contributor

@jooyoungseo, would it work for you if we focus the terminal when a letter key is pressed in the accessible view?

@meganrogge meganrogge modified the milestones: On Deck, November 2023 Oct 16, 2023
@jooyoungseo
Copy link
Author

jooyoungseo commented Oct 16, 2023 via email

meganrogge added a commit that referenced this issue Oct 16, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 17, 2023
@meganrogge meganrogge added on-testplan on-release-notes Issue/pull request mentioned in release notes labels Oct 20, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants