Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test activity bar position #196272

Closed
3 tasks done
sandy081 opened this issue Oct 23, 2023 · 0 comments
Closed
3 tasks done

Test activity bar position #196272

sandy081 opened this issue Oct 23, 2023 · 0 comments

Comments

@sandy081
Copy link
Member

sandy081 commented Oct 23, 2023

Ref: #118692

Complexity: 4

Create Issue


You can now move Activity Bar to the top of side bar. When it is located on top of the side bar, Accounts and Settings actions are moved to the custom title bar to the right.

  • There is an action Activity Bar Position in the context menu of the activity bar to move it.
  • There are commands in command pallette to move
  • There is a setting workbench.activityBar.location (source of truth) to configure the location
  • This feature is enabled only when title bar is custom "window.titleBarStyle" = "custom".
  • This feature is disabled when native tabs is enabled "window.nativeTabs" = true.
  • Badges are displayed on the view container icons in both primary and secondary side bar
  • Pinned and Badges hidden state is remembered across locations
  • View container icons overflow into overflow menu based on the width of the side bar
  • Drag and Drop view containers across side bars and panel.
  • Views visibility actions are shown in the context menu of the activity bar when placed on top.
  • If you have setting workbench.activityBar.visible set, it should be migrated to setting workbench.activityBar.location.

Please do an exploratory testing of this feature.

@sandy081 sandy081 added this to the October 2023 milestone Oct 23, 2023
sandy081 added a commit that referenced this issue Oct 23, 2023
sandy081 added a commit that referenced this issue Oct 23, 2023
* fix #196272

* fix reload
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 23, 2023
@sandy081 sandy081 removed the unreleased Patch has not yet been released in VS Code Insiders label Oct 23, 2023
@sandy081 sandy081 reopened this Oct 23, 2023
@sandy081 sandy081 changed the title Test activity bar position on top Test activity bar position Oct 23, 2023
@benibenj benibenj removed their assignment Oct 24, 2023
@justschen justschen removed their assignment Oct 24, 2023
@paulacamargo25 paulacamargo25 removed their assignment Oct 24, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants