Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions not loading #19753

Closed
everdrone opened this issue Feb 2, 2017 · 21 comments
Closed

Extensions not loading #19753

everdrone opened this issue Feb 2, 2017 · 21 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release extensions Issues concerning extensions important Issue identified as high-priority verified Verification succeeded

Comments

@everdrone
Copy link

  • VSCode Version: 1.9
  • OS Version: Windows 10

None of the installed extension are reloading, the reload button won't disappear.

capture

Anyway extensions are still on my machine, they just won't load.

@calebcartwright
Copy link

Ditto

@calebcartwright
Copy link

Might be a duplicate of #19685 (although that is 1.8.1) Mine was working just fine on 1.8.1, upgrade to 1.9 broke it

@tSte
Copy link

tSte commented Feb 3, 2017

The same here... but on Windows 8.1.

@M0ns1gn0r
Copy link

M0ns1gn0r commented Feb 3, 2017

The same for me, extensions broke after the upgrade (Win 8.1).

BTW, this is definitely not a duplicate of #19685, because now extensions do not work.

@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

@everdrone Sorry that you get this unexpected experience. I am not seeing this behavior but I am on Mac. I would try to reproduce this on Windows. Mean while can you help us in knowing how did you get into this state... Are you seeing all installed extensions in Reload state after opening VS Code? Or there any steps to follow to get into this state. Thanks

@everdrone
Copy link
Author

everdrone commented Feb 3, 2017

@sandy081 There are no steps to follow to reproduce this behavior, i just opened VS Code and updated to 1.9 by clicking on the latest release popup message.

I also tried to start code with code --disable-extensions. tried to uninstall and reinstall some extensions but nothing changed.

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Feb 3, 2017
@tSte
Copy link

tSte commented Feb 3, 2017

@sandy081 It is very strange behavior, because:

  • a colleague of mine did update right after me and she did not experience any problems at all (Win 10 x64)
  • I tried to install back VSCode 1.8.1 and extensions did not have any "Reload" buttons, but they did not work. When I updated back to 1.9.0, extensions are still not working, and every one of them (except disabled ones) do have "Reload" buttons
  • The settings.json does not recognize any extension-specific settings (it shows problems).
  • Freshly installed extensions share similar behavior.

Edit:
I removed my .vscode/extensions folder, then started to install extensions again. They are working. Have you changed some references or something in 1.9.0?

@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

@tSte Thanks for sharing the information. Can you please open developer tools by doing

  • Open command pallette (F1 or Ctrl+Shift+P)
  • Look for the command Toggle Developer Tools
  • Again open command pallette
  • Look for command Reload Window

Look for any errors in the opened dev tools console, if there are please let us know.

@sandy081 sandy081 added the important Issue identified as high-priority label Feb 3, 2017
@danielpunct
Copy link

danielpunct commented Feb 3, 2017

In my case it was because of an extension named Angola, that could not be read properly. After I deleted the folder from extensions, from disk everything was ok.

@imaginarny
Copy link

I experienced the very same problem on WIN10. I tried to update two PCs with almost identical VSCode setup. Both ended up with the same result.

Then I realized I had modified one of extensions to my likings and renamed to my very own. So you can consider it as a private and unpublished extension. Extensions like this one don't appear in VSCode extensions menu. Deleting the extension solved this issue.

So you could try the following:

  • Check if you have any extension in your %userprofile%\.vscode\extensions folder which doesn't appear in VSCode extensions menu
  • Try to delete or move it from the folder and then restart VSCode

@tSte
Copy link

tSte commented Feb 3, 2017

mainThreadExtensionService.ts:110Failed to parse C:/Users/.../.vscode/extensions/vsdarkmod/package.json:

mainThreadExtensionService.ts:110
TypeError: Cannot set property 'isBuiltin' of undefined
at t.validate (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:85:9146)
at file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:85:9835
at Object.g [as _notify] (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:12333)
at Object.enter (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:16418)
at _run (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:17739)
at _error (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:17256)
at file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:32:27555
at C:\Program Files (x86)\Microsoft VS Code\resources\app\node_modules\graceful-fs\polyfills.js:284:29
at FSReqWrap.oncomplete (original-fs.js:123:15)

This is my old theme from legacy times - I did not even realize that it was still there. Removing it solved this issue. @sandy081 thank you for help!

Perhaps some better error handler for extension would be nice...

@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

@tSte Thanks for sharing the information, I will try to investigate why this is happening after upgrading to 1.9.

@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

@aeschli Do you think is it related to the change here ?

@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

@tSte Is it possible to provide the contents of package.json of that vsdarkmod extension?

@sandy081 sandy081 added the candidate Issue identified as probable candidate for fixing in the next release label Feb 3, 2017
@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

@aeschli Looks like, forgot to return null for invalid extensions description jsons and is returning undefined. Unfortunately, our validator is checking only for null.

@tSte
Copy link

tSte commented Feb 3, 2017

@sandy081 I am sorry, but I can't :( Shift+delete-ed entire extension... I might have some backup on my external HDD though...

@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

@tSte No worries.. I got the steps to reproduce it

  • Open package.json of any extension from the installed extensions folder
  • Edit it to make it invalid json.

Open VS Code and you see this behavior.

@joaomoreno joaomoreno added this to the January Recovery 2017 milestone Feb 3, 2017
sandy081 added a commit that referenced this issue Feb 3, 2017
@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

Pushed to 1.9 branch & master

@aeschli
Copy link
Contributor

aeschli commented Feb 7, 2017

verified in 3e400cc

@aeschli aeschli added the verified Verification succeeded label Feb 7, 2017
@gerane
Copy link

gerane commented Mar 6, 2017

@aeschli I just upgraded to 1.11 and this is now happening on windows 10

@aeschli
Copy link
Contributor

aeschli commented Mar 7, 2017

@gerane Can you file a new issue with more information?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release extensions Issues concerning extensions important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

10 participants