-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aria-live updates related to the accessible view overlap with the announcement of the focused control when navigating the VS Code UI with NVDA #199959
Comments
Thanks for the report. It shouldn't be reading info about the accessible view in this case. |
@rperez030 last iteration, for keyboard only users, we added support for showing the tooltip on keyboard focus of status bar items. I had only tested this with a screen reader on macOS. I'll be curious to see why this is causing an issue on windows. |
I'm debugging with NVDA. Each time an element in the status bar gains focus, NVDA reports a liveRegionChange associated with the announcement "Inspect this in the accessible view with Alt+F2". If I press alt +F2, the name of that control appears in the accessible view.The live region update is taking precedence over the focus changed event. The same announcement is present on the mac, but over their voiceover is prioritizing the focus event over the live region update, so the control that receives focus is announced first. The same happens with JAWS in windows. |
To verify, on windows, enable NVDA. Focus the status bar / activity bar. Use arrow keys. Verify that there's no message about opening the accessible view. Focus a hover in the editor using only the keyboard. Verify that you do hear a message about opening the accessible view. |
This was verified in insider's by @rperez030. Will leave it without the label to also verify in the stable build. |
Type: Bug
When navigating the UI using the keyboard, NVDA reads the announcement related to the accessible view before the controls that receives focus. I'm finding this to be quite a bad experience, and potentially a big issue for more beginner users of the editor. An easy way to reproduce the problem is by pressing F6 from the editor to focus the status bar and use the arrow keys to move between elements. The issue only seems to affect NVDA at the moment. It may be good to give some time to fire these updates after the control receives focus, especially if the user is navigating quickly through nearby controls like in the status bar. In fact, I wonder what is the benefit of showing just the name of controls and potentially some descriptive text in the accessible view.
@isidorn @meganrogge
VS Code version: Code - Insiders 1.85.0-insider (94a3d7b, 2023-12-01T19:00:32.802Z)
OS version: Windows_NT arm64 10.0.22631
Modes:
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: unavailable_off
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: