-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picker is slow when used with many thousand elements #20136
Comments
Two reasons: we use the list widget for IntelliSense which is super fast and does not have high update cost when updating the tree. Second, quick open actually limits the number of results to some value, at least for file search. CPU trace attached: |
The original slowness is no longer there (the one from the tree), when I now test it with 10000 elements the majority of time is spend in So bottom line, switching to the list widget as we do in IntelliSense will not yield much better results imho. |
@isidorn this might be resolved if we switch to using a list for quick pick. |
Closing as duplicate of using a list for quick pick. Till then this is just a consequence of us using a tree which we do not plan to change afaik |
Most time is spent comparing entries. |
We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding and happy coding! |
Steps to Reproduce:
Here a sample how it looks like:
The text was updated successfully, but these errors were encountered: