Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code view scrolls when code lens is dismissed #20578

Closed
nicot opened this issue Feb 14, 2017 · 1 comment
Closed

Code view scrolls when code lens is dismissed #20578

nicot opened this issue Feb 14, 2017 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug code-lens verified Verification succeeded
Milestone

Comments

@nicot
Copy link

nicot commented Feb 14, 2017

  • VSCode Version: 1.9.1
  • OS Version: macOS Sierra 10.12.3

Steps to Reproduce:

  1. Enable a code lens
  2. Scroll down to a position where there is a code lens above the rendered lines
  3. Disable the code lens

Result:
The code scrolls up a couple lines.

Expected:
Center line should stay centered.

I'm not sure this ever happens in VSCode proper, but embedding it on sourcegraph.com exhibits the issue. If you go here: https://sourcegraph.com/github.com/gorilla/mux/-/blob/mux.go#L52:74 and click the Show authors button a couple times it exhibited the issue before b86e321 was applied. That patch might be a starting point, but it probably needs additional checks.

@alexdima
Copy link
Member

Reproducible when toggling editor.codeLens from true to false.

20578

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Apr 26, 2017
@alexdima alexdima added this to the Backlog milestone Apr 26, 2017
@alexdima alexdima modified the milestones: Backlog, April 2018 Apr 25, 2018
@mjbvz mjbvz added the verified Verification succeeded label Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug code-lens verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants