Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models getting disposed randomly #2080

Closed
bpasero opened this issue Jan 18, 2016 · 3 comments
Closed

Models getting disposed randomly #2080

bpasero opened this issue Jan 18, 2016 · 3 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
Jan 2016

Comments

@bpasero
Copy link
Member

bpasero commented Jan 18, 2016

I am still from time to time seeing errors where the code editor model seems to be disposed while the workbench model thinks the model is still alive:

image

This one happened after unstaging a change in sash.ts and then trying to open it.

@jrieken @alexandrudima fyi, any ideas who would still dispose models without going through the workbench?
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jan 18, 2016
@bpasero bpasero added this to the Jan 2016 milestone Jan 18, 2016
@jrieken
Copy link
Member

jrieken commented Jan 18, 2016

Hard to tell, after my change of only disposing documents from contributed schemes I haven't seen this...

@alexdima
Copy link
Member

I haven't seen this either.

@alexdima alexdima assigned jrieken and unassigned alexdima Jan 18, 2016
@jrieken
Copy link
Member

jrieken commented Jan 18, 2016

@bpasero please reopen if this remains

@jrieken jrieken closed this as completed Jan 18, 2016
@jrieken jrieken assigned joaomoreno and unassigned jrieken Jan 26, 2016
@joaomoreno joaomoreno added the verified Verification succeeded label Jan 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
Jan 2016
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @jrieken @alexdima