Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "return to top" control to Extension details view #20823

Closed
gregvanl opened this issue Feb 17, 2017 · 1 comment
Closed

Add "return to top" control to Extension details view #20823

gregvanl opened this issue Feb 17, 2017 · 1 comment
Assignees
@mjbvz
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2018

Comments

@gregvanl
Copy link

gregvanl commented Feb 17, 2017 •
edited

This came up in a discussion with the C++ extension team. They are going to move their setup and configuration steps out of our docs to their extension README. They were concerned that the README would be long and navigation would be problematic. They can add H2 header links at the top (like we do for our in-product release notes) but would need the same "return to top" support as our in-product release notes.

The current implementation in the release notes are embedded HTML elements.
It would be nice to embed these elements in all the Extension details view renderings.

<a id="scroll-to-top" role="button" aria-label="scroll to top" onclick="scroll(0,0); event.preventDefault(); event.stopPropagation()"><span class="icon"></span></a>
<link rel="stylesheet" type="text/css" href="css/inproduct_releasenotes.css"/>
@gregvanl
Copy link
Author

@waderyan @seanmcbreen This would help with viewing multi-page extension READMEs in the Extension details view.

@gregvanl gregvanl added the feature-request Request for new features or functionality label Feb 17, 2017
@mjbvz mjbvz self-assigned this Jun 14, 2017
@bpasero bpasero added the extensions Issues concerning extensions label Nov 17, 2017
@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Nov 30, 2017
@mjbvz mjbvz added this to the December 2017/January 2018 milestone Dec 21, 2017
@mjbvz mjbvz added verification-needed Verification of issue is requested and removed help wanted Issues identified as good community contribution opportunities labels Dec 21, 2017
@mjbvz mjbvz closed this as completed in 8e91f6e Dec 21, 2017
@gregvanl gregvanl added the verified Verification succeeded label Dec 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
3 participants
@bpasero @gregvanl @mjbvz